Prevent crashing when using item of "effect_on_conditions" type #68976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[C++]
github-actions
bot
added
the
BasicBuildPassed
Maleclypse
pushed a commit
to Maleclypse/Cataclysm-DDA
that referenced
this pull request
Nov 16, 2023
…erRaven#68976) * Prevents crash from trying to spend charge with item cleared * better handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
When starting EoC using an item of type "effect_on_conditions", the game may crash if you consume the item with something like "u_consume_item" function
Describe the solution
This is caused by attempting to consume more charges on an item after it has been deleted.
If the item has already been erased for some reason, you can avoid the crash by not consuming charges.
Describe alternatives you've considered
Add
u_consume_itemto the processing of the itemnre_recorderEoC.I confirmed that even if you erase
nre_recorderin EoC, it will not crash.Testing
Additional context