Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portal Dependent Update #68922

Merged
merged 6 commits into from
Oct 27, 2023

Conversation

Termineitor244
Copy link
Contributor

@Termineitor244 Termineitor244 commented Oct 26, 2023

Summary

Content "Updates the Portal Dependent mechanics and introduces rewards for exploring the portal dungeons."

Purpose of change

I have always wanted for portal dungeons to reward portal dependent characters with something appropriate for them and for it to be possible to permanently improve your grasp of reality by exploring them, and I finally found the time (And creativity) to do it!

When doing this I noticed that some aspects of the EoCs of their mechanics were in need of an update since the change from static portal storms to mobile/regional portal storms, so I went and updated them too.

Describe the solution

Adds a new effect that represents a temporal alignment/subversion of the local reality to accommodate your unstable state in the world, given by exploring the portal dungeon and improving the more levels you complete, with the final possible reward being the "Stabilized in Reality" trait that permanently disables the worst effects of the portal dependent trait and improves your chances of benign effects when suffering from your lack of portal storms.

The trait already existed, but the only way to obtain it was by exposing yourself to the portal storms for a significant time, so it was necessary a more proactive method, even if equally dangerous.

Edit: Also added some more professions to the scenario! Mainly researchers/guinea pigs from labs that could have ended up caught in this dimensional travel business, You can now select from any of the mutations that the mutated scenarios use too! Since being trapped in a portal storm of this magnitude can definitely change you in strange ways. You will now start with some debuffs too to emphasize your distorted presence and the initial damage from being involved in something like this.

Added mod professions to the scenario when appropriate! Now your nether touched psychics can start in the middle of the portal storm that gave them their powers!

Describe alternatives you've considered

To implement the effect as an artifact like my first mental draft of this? I ended up doing it this way but I´m not against adding different rewards in the shape of an artifact that helps you lessen your reality decay problems.

Testing

it loads! The effects appear and work on the player! They are given when completing the appropriate levels of the portal dungeon! You can gain the stabilization trait by making a deep exploration of the dungeon! I have make testing seeing of the professions/traits appear in the mod and seeing that portal dungeon standard rewards are not affected by this changes, it all seems to work fine.

Additional context

I would like to add some new EoCs with more effects of the reality rejecting you, specially as a consequence of abusing portal dungeons and bringing instability to your surroundings just by trying to make the world fit you again in it. But my creative mind has dried up for now so maybe later or in another PR...

imagen

This PR was planned since 2 years ago! Here

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON EOC: Effects On Condition Anything concerning Effects On Condition json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Oct 26, 2023
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Oct 26, 2023
@github-actions github-actions bot added Mods Issues related to mods or modding Scenarios New Scenarios, balancing, bugs with scenarios Mods: Magiclysm Anything to do with the Magiclysm mod Mods: MMA Mythical Martial Arts mod Mods: Innawood 🌲 Anything to do with Innawood mod Mods: Mind Over Matter labels Oct 26, 2023
@Termineitor244 Termineitor244 marked this pull request as ready for review October 26, 2023 18:40
@github-actions github-actions bot requested a review from KorGgenT October 26, 2023 18:40
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-requesting reviews from non-collaborators: @Hymore246 @GuardianDll @Standing-Storm @Light-Wave

@freepizzas-dev
Copy link

"Why did the hit went that way?" should probably be "Why did the hit go that way?"

@Termineitor244
Copy link
Contributor Author

"Why did the hit went that way?" should probably be "Why did the hit go that way?"

Done, thanks!

@freepizzas-dev
Copy link

Sorry, another one:

"You could have swear you hit it!" -> "You could've sworn you hit it!" or "You could swear that you hit it!"

@Termineitor244
Copy link
Contributor Author

Sorry, another one:

"You could have swear you hit it!" -> "You could've sworn you hit it!" or "You could swear that you hit it!"

Done! And don't worry, thanks for the help!

@Maleclypse Maleclypse merged commit a02ffd7 into CleverRaven:master Oct 27, 2023
@Termineitor244 Termineitor244 deleted the Portal-Dependent-update branch October 27, 2023 03:48
Maleclypse added a commit to Maleclypse/Cataclysm-DDA that referenced this pull request Nov 16, 2023
* Portal Dependent Update

* Ellipsis fix

* Update numbers and scenario

* Went -> Go

* Swearing

* Update data/json/effects.json

Co-authored-by: Maleclypse <[email protected]>

---------

Co-authored-by: Maleclypse <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions EOC: Effects On Condition Anything concerning Effects On Condition [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Innawood 🌲 Anything to do with Innawood mod Mods: Magiclysm Anything to do with the Magiclysm mod Mods: Mind Over Matter Mods: MMA Mythical Martial Arts mod Mods Issues related to mods or modding Scenarios New Scenarios, balancing, bugs with scenarios
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants