Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved random spawns #68684

Merged
merged 5 commits into from
Oct 16, 2023
Merged

Conversation

Termineitor244
Copy link
Contributor

Summary

Balance "Adds more spawns to several items"

Purpose of change

I have noticed some items that lack appropriate spawns or have possible improvements to be made for those spawns, so I went and did them!

Describe the solution

Adds more global spawns for the Javelin Bag, Nylon Quiver, Lanyard and Skateboard.
Improved the spawns for quivers giving them the possibility to spawn loaded with arrows in appropriate locations (The main one being the hunting store), now the arrows and bolts of the world have a proper place to be stored! It will still be rare to find the quivers with ammo, but now there is a chance when looting appropriate places!

Describe alternatives you've considered

None.

Testing

Started the game, it starts, loaded quivers can be found in hunting stores, skateboards in the school, etc.

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display Spawn Creatures, items, vehicles, locations appearing on map Game: Balance Balancing of (existing) in-game features. json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Oct 15, 2023
@PatrikLundell
Copy link
Contributor

I've never visited a hunting store, but it seems odd that they'd sell quivers with arrows in them, as there are different kinds of arrows and we live in a world where "batteries not included" is the standard mode.
The same goes for closets with general "stuff" where the owner tossed their no longer used items. In contrast, I'd expect places reserved for bows and arrows for actual use to have quivers stocked (unless there is some reason for why arrows shouldn't be stored in quivers, such as potentially the feathers becoming crooked from being stored there).

@Termineitor244
Copy link
Contributor Author

I've never visited a hunting store, but it seems odd that they'd sell quivers with arrows in them, as there are different kinds of arrows and we live in a world where "batteries not included" is the standard mode.
The same goes for closets with general "stuff" where the owner tossed their no longer used items. In contrast, I'd expect places reserved for bows and arrows for actual use to have quivers stocked (unless there is some reason for why arrows shouldn't be stored in quivers, such as potentially the feathers becoming crooked from being stored there).

The loaded quivers of the hunting store are specifically on the mannequins and in the storage area behind the counter (Where the arrows are), so I imagine it as exhibition for the mannequins (A hunting outfit with quiver and some arrows inside so the customer can see how they would look like with the items), the storage behind the counter already has the arrows there and I imagine it as just using some quivers for storing the arrows, not specifically because they are sold as sets.

With closets, I wasn't exactly sure if they could be put in there, but we have a lack of hunters/recreative archers storing their arrows in their houses, so I thought it would be appropriate, or is there a better place inside the house for a hunter to store them?

@Maleclypse Maleclypse merged commit f10798b into CleverRaven:master Oct 16, 2023
25 checks passed
@Termineitor244 Termineitor244 deleted the Improved-spawns branch October 16, 2023 20:37
detahramet pushed a commit to detahramet/Cataclysm-DDA that referenced this pull request Nov 6, 2023
* Quiver and Javelin bag spawns

* Loaded Quivers

* Lanyard spawns

* Skateboard spawns

* Lanyard fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Game: Balance Balancing of (existing) in-game features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants