Infarstructure: Move methods from npc to Character #68666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
NPC / Factions
18 tasks
ZhilkinSerg
reviewed
Oct 15, 2023
github-actions
bot
added
the
BasicBuildPassed
|
Note! I am assuming here that |
detahramet
pushed a commit
to detahramet/Cataclysm-DDA
that referenced
this pull request
Nov 6, 2023
* move is_ally to Character * move is_obeying to Character * get_characters_if * change return val of get_crafting_helpers to Character
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Closes #68657
Describe the solution
Whatever function I was changing, I read the whole thing to make it mention Characters instead of NPCs where appropriate.
Move methods that are necessary in #68183 from
npctoCharacter(supertype ofnpc). That PR will require this PR to get merged.In
Character, they are abstract methods.In
npcthey are as they used to be.In
Avatar, the code delegates the implementation to the already existing code innpc. Utilizing assumptions that two avatars cannot exist (in which case it would recursively call the other until it crashes from stack overflow).Describe alternatives you've considered
Testing
Compiling...
Additional context
More methods could be moved