Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow NPC docs to install & remove CBMs from NPCS #68630

Merged
merged 1 commit into from
Oct 14, 2023

Conversation

ehughsbaird
Copy link
Contributor

Summary

Features "Allow NPC doctors to install and remove CBMs from player allies"

Purpose of change

Fixes #68510
There's discussion in the issue about the lore around cyborgs and the exodii, so I only added this to the ancilla doc, who I don't think would care as long as they get paid.

Describe the solution

Add an appropriate NPC talk function for installation & removal that asks you to select an ally to install/remove from. Modify the menu for bionic install to have a "patron" that it will also check for CBMs to install from.

Give the ancilla doc, Doc. Stevens, appropriate dialogues to install and remove bionics from NPCs.

Describe alternatives you've considered

Something cleaner with the bionic install menu, but this was easy.
See above about adding it to more NPCs.

Testing

I don't know quite what triggers the ancilla to spawn, but I did a summer start, teleported to the hub and did the first mission, advanced the season to autumn, then went to the ancilla.
Once there, I spawned in an NPC companion, some hub gold coins, and some bionics.

Bionic installation and removal from ally

image
image
image
image
image
image

Additional context

This will knock the companion out with anesthetic right where they're sitting, which can get you stuck in the doctor's office. Not sure how to suitably resolve this.

Add an appropriate NPC talk function for installation & removal that
asks you to select an ally to install/remove from.
Modify the menu for bionic install to have a "patron" that it will also
check for CBMs to install from.

Give the ancilla doc, Doc. Stevens, appropriate dialogues to install and
remove bionics from NPCs.

Not added to the exodii because there may be various lore reasons they
would avoid it.
@github-actions github-actions bot added NPC / Factions NPCs, AI, Speech, Factions, Ownership [JSON] Changes (can be) made in JSON [C++] Changes (can be) made in C++. Previously named `Code` <Enhancement / Feature> New features, or enhancements on existing astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Oct 13, 2023
@Maleclypse Maleclypse merged commit cfcc682 into CleverRaven:master Oct 14, 2023
@ehughsbaird ehughsbaird deleted the which,-doctor branch October 14, 2023 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` <Enhancement / Feature> New features, or enhancements on existing [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NPCs cannot be operated on by Exodii/other NPC surgeons
2 participants