-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Martial arts homebook jsoning #68566
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Going to make it a extremely small chance for any martial arts book to spawn in any house. Emphasis on "extremely small"
github-actions
bot
added
[JSON]
Changes (can be) made in JSON
Spawn
Creatures, items, vehicles, locations appearing on map
new contributor
labels
Oct 8, 2023
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions
bot
added
json-styled
JSON lint passed, label assigned by github actions
astyled
astyled PR, label is assigned by github actions
labels
Oct 8, 2023
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Dan1ss1mo
suggested changes
Oct 12, 2023
Co-authored-by: Dan1ss1mo <[email protected]>
github-actions
bot
added
the
BasicBuildPassed
This PR builds correctly, label assigned by github actions
label
Oct 14, 2023
It is le mysanchezgamer, gamer of the....sanchezs? |
detahramet
pushed a commit
to detahramet/Cataclysm-DDA
that referenced
this pull request
Nov 6, 2023
* Martial arts homebook jsoning Going to make it a extremely small chance for any martial arts book to spawn in any house. Emphasis on "extremely small" * Update books.json * Apply suggestions from code review Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update books.json * Update data/json/itemgroups/books.json Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update data/json/itemgroups/books.json Co-authored-by: Dan1ss1mo <[email protected]> --------- Co-authored-by: Maleclypse <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Dan1ss1mo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
astyled
astyled PR, label is assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
[JSON]
Changes (can be) made in JSON
json-styled
JSON lint passed, label assigned by github actions
new contributor
Spawn
Creatures, items, vehicles, locations appearing on map
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Going to make it a extremely small chance for any martial arts book to spawn in any house. Emphasis on "extremely small".
Found it weird no houses really had any chance for MA's so here we are. 3 months in the makin. Feel free to comment as I'm still running tests on the code to make sure it doesn't do a kickflip and spawn like 80 MA books
Describe the solution
Adjusts itemgroups
Describe alternatives you've considered
none
Testing
Additional context