Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Martial arts homebook jsoning #68566

Merged
merged 6 commits into from
Oct 14, 2023
Merged

Conversation

Aracken43
Copy link
Contributor

@Aracken43 Aracken43 commented Oct 8, 2023

Summary

None

Purpose of change

Going to make it a extremely small chance for any martial arts book to spawn in any house. Emphasis on "extremely small".
Found it weird no houses really had any chance for MA's so here we are. 3 months in the makin. Feel free to comment as I'm still running tests on the code to make sure it doesn't do a kickflip and spawn like 80 MA books

Describe the solution

Adjusts itemgroups

Describe alternatives you've considered

none

Testing

Additional context

Going to make it a extremely small chance for any martial arts book to spawn in any house. Emphasis on "extremely small"
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Spawn Creatures, items, vehicles, locations appearing on map new contributor labels Oct 8, 2023
data/json/itemgroups/books.json Outdated Show resolved Hide resolved
data/json/itemgroups/books.json Outdated Show resolved Hide resolved
data/json/itemgroups/books.json Outdated Show resolved Hide resolved
data/json/itemgroups/books.json Outdated Show resolved Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Oct 8, 2023
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
data/json/itemgroups/books.json Outdated Show resolved Hide resolved
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Oct 14, 2023
@Maleclypse Maleclypse merged commit d6713bb into CleverRaven:master Oct 14, 2023
23 of 24 checks passed
@Aracken43
Copy link
Contributor Author

It is le mysanchezgamer, gamer of the....sanchezs?
THE PR GOT MERGED THANKS!

detahramet pushed a commit to detahramet/Cataclysm-DDA that referenced this pull request Nov 6, 2023
* Martial arts homebook jsoning

Going to make it a extremely small chance for any martial arts book to spawn in any house. Emphasis on "extremely small"

* Update books.json

* Apply suggestions from code review

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update books.json

* Update data/json/itemgroups/books.json

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update data/json/itemgroups/books.json

Co-authored-by: Dan1ss1mo <[email protected]>

---------

Co-authored-by: Maleclypse <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Dan1ss1mo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions new contributor Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants