Change Grim Reapers Scythe #68420
Merged
Change Grim Reapers Scythe #68420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[JSON]
github-actions
bot
added
the
Code: Tests
Karol1223
reviewed
Sep 30, 2023
github-actions
bot
added
the
BasicBuildPassed
detahramet
pushed a commit
to detahramet/Cataclysm-DDA
that referenced
this pull request
Nov 6, 2023
* Update landscaping.json * Update landscaping.json * Update landscaping.json * Update known_bad_density.json * Update known_bad_density.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Balance "Adjust Grim Reaper Scythe"
Purpose of change
A solid plastic toy is a luxury most people wouldn't have. So this PR changes it to be hollow. Didn't want to do the math of
Describe the solution
Removes techniques and nerfs damage, but reduced weight. Did some garbage math. Assumed the volume was a cylinder with 2.5mm wall thickness, giving 2932.75 cm^3 of empty space. Is it perfect? No. Did I have to do a bunch of math to try to find out what the actual volume would be? No. Should I have just searched up a toy and get its weight from the product page? Probably. Also adds it to the known bad density json, don't know if that was needed or not
Describe alternatives you've considered
Forcing kids to grow up and use real scythes as toys.
Testing
Why not?
Additional context