Add a larger “family–sized” water heater #68404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This one has a 55–gallon tank; naturally deconstructing it yields a `55gal-drum` of the same capacity. For consistency, the stats are taken from a Rheem model XG55T06EC50UO water heater <https://images.thdstatic.com/catalog/pdfImages/7e/7e7928b1-8b4f-472a-8ee8-b48eb1e7932a.pdf>.
Anode rods for water heaters are typically aluminum or magnesium, as these metals have good electronegativity and don’t cost very much. CDDA doesn’t have magnesium metal chunks or ingots, but it does have aluminum, so it is easiest to always use aluminum.
For some buildings I left the existing small water heater as is, for a few (such as the landromat) I changed it to a larger one, but for most I left it to chance. I didn’t add water heaters to any building that doesn’t already have one.
github-actions
bot
added
[JSON]
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
added
json-styled
GuardianDll
reviewed
Sep 30, 2023
It looks like the water heaters are mostly in the barracks, infirmary, etc, so it makes sense that they would use large ones. If 100–gallon commercial water heaters are ever added to the game, this would be a great place to use them.
github-actions
bot
removed
the
BasicBuildPassed
GuardianDll
reviewed
Oct 1, 2023
Co-authored-by: Anton Simakov <[email protected]>
|
I accepted your suggestion for water heater sizes on the carrier map, but I am not entirely sure that a modern carrier would have any water heaters at all. I’ve never encountered it in the game and I haven’t looked at the map, but it seems to me that a nuclear carrier would use the reactor to heat water and then pipe it around the ship instead of making electricity that is then converted back into heat in a water heater. But if the map has water heaters, we might as well make them large ones :) |
github-actions
bot
added
the
BasicBuildPassed
detahramet
pushed a commit
to detahramet/Cataclysm-DDA
that referenced
this pull request
Nov 6, 2023
* Add a larger “family–sized” water heater This one has a 55–gallon tank; naturally deconstructing it yields a `55gal-drum` of the same capacity. For consistency, the stats are taken from a Rheem model XG55T06EC50UO water heater <https://images.thdstatic.com/catalog/pdfImages/7e/7e7928b1-8b4f-472a-8ee8-b48eb1e7932a.pdf>. * add sacrificial anode rods to water heaters to prevent corrosion Anode rods for water heaters are typically aluminum or magnesium, as these metals have good electronegativity and don’t cost very much. CDDA doesn’t have magnesium metal chunks or ingots, but it does have aluminum, so it is easiest to always use aluminum. * update a wide variety of buildings to use the larger water heaters For some buildings I left the existing small water heater as is, for a few (such as the landromat) I changed it to a larger one, but for most I left it to chance. I didn’t add water heaters to any building that doesn’t already have one. * lint the json * make the military base use the larger water heaters It looks like the water heaters are mostly in the barracks, infirmary, etc, so it makes sense that they would use large ones. If 100–gallon commercial water heaters are ever added to the game, this would be a great place to use them. * make the carrier only use the larger water heaters as well Co-authored-by: Anton Simakov <[email protected]> --------- Co-authored-by: Anton Simakov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Content "Add a larger “family–sized” water heater"
Purpose of change
Prior to the cataclysm it was common for larger households to have installed larger water heaters so that everybody could take a hot shower every night. Commercial establishments frequently required larger water heaters in order to serve customers reliably as well. Mapgen doesn’t reflect these facts well.
Describe the solution
Adds one larger size of water heater, with a 55–gallon capacity.
Describe alternatives you've considered
75 and 100–gallon water heaters are not uncommon, but that would require adding more tank objects.
Testing
make checkfor syntax, and I wandered around a world verifying that both sizes were available.Additional context