Deconstructing a water heater yields a 100L tank instead of 60L

[db48x]

Summary

Balance "Deconstructing a water heater yields a 100L tank instead of 60L (plus the usual bits and bobs)."

Purpose of change

Fixes #68316

Describe the solution

I did a quick search for water heaters on the website of the nearest home improvement store and found that the Rheem model XE36S06ST45U0 is a good match for the stats of the existing household_water_heater item at 240L exterior volume and 54kg mass. See
https://images.thdstatic.com/catalog/pdfImages/2d/2d7ed116-1a8c-439d-b7fe-a62a0a98f806.pdf for published dimensions.

As this water heater has an internal capacity of 36 US gallons (136L), I changed the deconstruction recipe to yield a 100L tank instead of the 60L it used to be. I also changed the keg_capacity of the heater to match.

Describe alternatives you've considered

I originally intended to use the 200L 55gal_drum for this change, primarily because I myself have a 50–gallon heater. However, I noticed that this didn’t leave a lot of room for insulation, and went looking for specifications on real water heaters.

Of course, this size of water heater is intended for use in small apartments; larger houses would have larger heaters (up to 100 gallons even). I’m resisting the temptation to add another size or two just on general principle, but I note that mansions do exist.

Testing

I tested this by disassembling a water heater and noting that I got a 100L tank as intended. Later I noticed that the keg_capacity was off; turns out that it's in cups not liters.

Additional context

[GuardianDll]

> I’m resisting the temptation to add another size or two

Just add it, i don't see any reason to not

[db48x]

To do that well I would want to update the mapgen for the mansion and perhaps some of the larger houses, but that’s a lot more than I want to do tonight. :)

[GuardianDll]

Sure. Fyi mapgen allows to define variants of the same terrain/furniture, so for most places you can make simple replacement "@": "f_water_heater" -> "@": [ [ "f_water_heater", 7 ], [ "f_water_heater_big", 3] ] so the game would generate 70% of default water heaters, and 30% of big water heaters, or something similar

[db48x]

Yes, I did something similar for a different patch I’m working on (unrelated to water heaters).