Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the token bash damage on belts #68254

Merged

Conversation

gettingusedto
Copy link
Contributor

@gettingusedto gettingusedto commented Sep 22, 2023

Summary

None

Purpose of change

After some discussion at the devcord, the bash damage on belts is completely arbitrary and probably should be removed, so i did it.

Describe the solution

Delete the melee damage on belts in the belts.json

Describe alternatives you've considered

Not removing the melee damage but only reducing it to 1.

Testing

Before i applied the change into my build, the five affected belts (broad belt, firefighter belt, leather belt, police duty belt, and tool belt) has the melee stats in their (e)xamine screen. it doesnt appears after i applied the change to my build.

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Items: Armor / Clothing Armor and clothing astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Sep 22, 2023
@KHeket
Copy link
Contributor

KHeket commented Sep 22, 2023

This logic is incorrect. The damage of fists hits in reality is calculated from lots of values, but we will take in mind for this case only 2 of them - speed and weight. The more heavier you hand is and the more fast you hit is - the mor damage you will deal. This is princeples of knuckles. You can even take a fire lighter - it will have 1-10-40+ gramm weight, but it also make your hit a bit more powerfull. And also metal belt buckle is hard, what is positively work on damage
As exapmle - molle belt. It have 210g weight, when steel knuckles have weight of 240 gramm, but knuckles was consructed for melee fight. So I thinks, it better to leave at least 1-3 bash damage to belts determinated on their weight

@Karol1223
Copy link
Contributor

Karol1223 commented Sep 22, 2023

As exapmle - molle belt. It have 210g weight, when steel knuckles have weight of 240 gramm, but knuckles was consructed for melee fight. So I thinks, it better to leave at least 1-3 bash damage to belts determinated on their weight

This completely ignores material hardness and surface area of the hit and is blatantly incorrect. Hitting someone with a heavy jacket that weighs a kilogram will still do significantly less damage than hitting someone with steel knuckles that weigh 1/4 of that. Hitting someone with a belt does basically no meaningful damage and only causes pain - which is irrelevant for anything but the player. Belts should not be a weapon in any circumstances.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Sep 22, 2023
@KHeket
Copy link
Contributor

KHeket commented Sep 22, 2023

Hitting someone with a belt does basically no meaningful damage and only causes pain

Read again my first message. You dont significantly inrease surface area of your fist by wrapping belts around it, but you significantly inrease the wieght of your fist, so belts can be used as a melee weapon, such in real life

@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Sep 22, 2023
@Karol1223
Copy link
Contributor

Karol1223 commented Sep 22, 2023

You dont significantly inrease surface area of your fist by wrapping belts around it, but you significantly inrease the wieght of your fist, so belts can be used as a melee weapon, such in real life

So we assume wrapping the belt around your knuckles instead of whipping it - this changes things but not significantly. Increasing surface area is minimal, yes, but you're still just wrapping leather around your hand - unless you're hoping to hit someone with the buckle you're not doing any more damage than you'd be without the belt. And even then, hitting someone with a buckle would be similar to stabbing someone with a key - it would hurt, but not do any meaningful damage unless you hit an eye or something like this. Belts should not be useful weapons under any circumstances, because we can't simulate pain on monsters.

The main benefit of wrapping a belt around your knuckles would be to protect your knuckles from getting damaged - which, again, we don't simulate.

@KHeket
Copy link
Contributor

KHeket commented Sep 22, 2023

but you're still just wrapping leather around your hand

You understand the way of fist hit in wrong way. The weight of fist is ~ 400 grams
image
So, lets undestand it as 100% of character fist hit damage. If you wrap aroind it a 210 grams molly belt - you will increase the weigt of you fist by 50%. Yes, you will not kill guys with fists in this way, but it will increase damage of hit a bit

@Karol1223
Copy link
Contributor

Karol1223 commented Sep 22, 2023

So, lets undestand it as 100% of character fist hit damage. If you wrap aroind it a 210 grams molly belt - you will increase the weigt of you fist by 50%. Yes, you will not kill guys with fists in this way, but it will increase damage of hit a bit

You're still ignoring material hardness - you're wrapping 200g of soft leather (or I suppose nylon in the case of MOLLE) that will add weight, while also adding padding to the hit both for you and the target. Combine that with the minor increase in surface area - you end up with roughly equivalent damage unless you happen to hit the target with the buckle. I do not believe this warrants 1 guaranteed additional bash, and it 100% does not warrant anything more than 1.

@KHeket
Copy link
Contributor

KHeket commented Sep 22, 2023

The damage(impulse) of fists hit is calculated from weight, speed and surface area of you hand. If we increase the weight of it - the damage will be increased

while also adding padding to the hit both for you and the target.

Belt leather is hard. And the boxer wearing much more soft and much more better as padding boxer gloves, but they also make a lot of damage to opponents. And the fist damage not only surface damage, you dont need to pierce and cut skin like in case with key, impulse of you hit like in boxing - strike inside, it damaging organs, brain (concussion), bones etc

@Karol1223
Copy link
Contributor

And the boxer wearing much more soft and much more better as padding boxer gloves, but they also make a lot of damage to opponents.

Boxing gloves exist specifically to DECREASE the impact force, though. I genuinely don't understand where you're going with this. A belt is not damaging enough by itself to function as a proper weapon, I said everything I had to say. This is genuinely not at all important either way, because I refuse to believe anyone but NPCs have ever used belts as weapons - and this change will make NPCs choose them more rarely, at least in theory. I support this change and I've said everything there is to be said. Further comments would jut be going in circles.

@KHeket
Copy link
Contributor

KHeket commented Sep 22, 2023

I genuinely don't understand where you're going with this

In realism

@MNG-cataclysm
Copy link
Contributor

Never before have I witnessed such an argument over belts, of all things.

@Karol1223
Copy link
Contributor

Never before have I witnessed such an argument over belts, of all things.

Here in the CDDA repository we only discuss the most important things that will certainly actually matter in game for the players.

@Maleclypse Maleclypse merged commit a18447b into CleverRaven:master Sep 22, 2023
@gettingusedto gettingusedto deleted the belt-melee-damage-removal branch September 22, 2023 18:29
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Items: Armor / Clothing Armor and clothing [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants