Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Random cleanups part 3 #68216

Merged
merged 5 commits into from
Sep 21, 2023
Merged

Random cleanups part 3 #68216

merged 5 commits into from
Sep 21, 2023

Conversation

GuardianDll
Copy link
Member

@GuardianDll GuardianDll commented Sep 19, 2023 •
edited
Loading

Summary

None

Purpose of change

There is a lot of stuff in the game, that was created, but never got used, or things that we got rid of, but not completely. I'd like to clean some of them

Describe the solution

Removed, if not mentioned otherwise:

  • hive_center
  • library_elec
  • mine_storage
  • flower_shop
  • key_shop
  • tux_shop
  • victoria_shop
  • sewing_room
  • voyer
  • private_resort_gambling_table
  • player_crafted
  • mil_bulk
  • some_front_plates
  • sus_books_fict_soft_romc
  • mre_used_accessory_pack
  • tools_fishing_makeshift
  • ammo_casings_bulk
  • ammo_smg_reloaded
  • ammo_box_300blk - added to 300blk set as intended, instead of 308
  • police_armory_full_glockmag_9mmp
  • police_armory_full_glockmag_9mmp2
  • police_armory_full_m9mag_9mmp
  • police_armory_full_m9mag_9mmp2
  • police_armory_full_usp9mag_9mmp
  • police_armory_full_usp9mag_9mmp2
  • gunmod_archery
  • sights_all
  • sights_launcher
  • sights_pistol
  • sights_smg
  • guns_shotgun_rare_static_display
  • mags_obscure_gunstore
  • mags_other_rare
  • nested_greasegun - added to guns_rifle_rare
  • nested_rfb_308 - added to guns_rifle_rare
  • nested_zpap85 - added to guns_rifle_rare with nested_zpapm90 (was in guns_rifle_common previously)

Additional context

Item groups are done, at least in vanilla

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Items: Magazines Ammo holding items and objects. Items: Gunmod / Toolmod Weapon and tool attachments, and add-ons Spawn Creatures, items, vehicles, locations appearing on map Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves Items: Armor / Clothing Armor and clothing astyled astyled PR, label is assigned by github actions labels Sep 19, 2023
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Sep 19, 2023
@Maleclypse Maleclypse merged commit c14b1ec into CleverRaven:master Sep 21, 2023
@GuardianDll GuardianDll deleted the cleanup_3 branch September 21, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@Maleclypse Maleclypse Maleclypse approved these changes

Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves Items: Armor / Clothing Armor and clothing Items: Gunmod / Toolmod Weapon and tool attachments, and add-ons Items: Magazines Ammo holding items and objects. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuardianDll @Maleclypse