Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random cleanups part 1 #68108

Merged
merged 19 commits into from
Sep 19, 2023
Merged

Random cleanups part 1 #68108

merged 19 commits into from
Sep 19, 2023

Conversation

GuardianDll
Copy link
Member

@GuardianDll GuardianDll commented Sep 12, 2023

Summary

None

Purpose of change

There is a lot of stuff in the game, that was created, but never got used, or things that we got rid of, but not completely. I'd like to clean some of them

Describe the solution

Removed, if not mentioned otherwise:

  • emit_acid_splash
  • emit_hot_air4_blast
  • emit_hot_air1_cbm
  • emit_hot_air2_cbm
  • emit_hot_air3_cbm
  • emit_hot_air4_cbm
  • emit_cold_energy_weak
  • ench_climate_control_cold
  • f_glassedbody_11 - added into the list of vitrified bodies
  • f_vitrified_rack_coat
  • f_vent_rad_cloud
  • f_vent_smoke_plume
  • f_vent_smoke_stream
  • f_robotic_assembler
  • f_console_table
  • f_standing_pressure_tank
  • nre_zero_reading_printout
  • scrap_denim - added as byproduct into recipes that uses denim
  • scrap_faux_fur - added as byproduct into recipes that uses faux fur
  • scrap_lycra - added as byproduct into recipes that uses lycra
  • grinder_cutoff_disc - got added to the angle grinder spawns
  • grinder_metal_grinding_disc - same
  • bio_powershot
  • gun_crossbow_mod - removed since the only difference of it from gun_crossbow is you can put it on launcher

@github-actions github-actions bot requested a review from KorGgenT September 12, 2023 13:42
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Bionics CBM (Compact Bionic Modules) Map / Mapgen Overmap, Mapgen, Map extras, Map display Spawn Creatures, items, vehicles, locations appearing on map Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Mods: Magiclysm Anything to do with the Magiclysm mod Mechanics: Enchantments / Spells Enchantments and spells json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Sep 12, 2023
@GuardianDll GuardianDll marked this pull request as draft September 13, 2023 11:50
@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Sep 13, 2023
@github-actions github-actions bot added the Items: Armor / Clothing Armor and clothing label Sep 13, 2023
@github-actions github-actions bot added the Items: Containers Things that hold other things label Sep 13, 2023
@GuardianDll GuardianDll marked this pull request as ready for review September 13, 2023 12:54
@GuardianDll
Copy link
Member Author

Now this is not "random cleanup" PR, now it's "random apparel disassemble recipes" PR

Copy link
Contributor

@Karol1223 Karol1223 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for listening ❤️

data/json/items/resources/tailoring.json Outdated Show resolved Hide resolved
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Sep 18, 2023
@Maleclypse Maleclypse merged commit 2c66024 into CleverRaven:master Sep 19, 2023
@GuardianDll GuardianDll deleted the cleanup branch September 19, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Bionics CBM (Compact Bionic Modules) Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Items: Armor / Clothing Armor and clothing Items: Containers Things that hold other things [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display Mechanics: Enchantments / Spells Enchantments and spells Mods: Magiclysm Anything to do with the Magiclysm mod Mods Issues related to mods or modding Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants