Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPC Elvira Fish, Circulations #68081

Merged
merged 26 commits into from
Oct 12, 2023
Merged

NPC Elvira Fish, Circulations #68081

merged 26 commits into from
Oct 12, 2023

Conversation

LyleSY
Copy link
Contributor

@LyleSY LyleSY commented Sep 10, 2023

Summary

Content "NPC Elvira Fish, Circulations"

Purpose of change

NPC to start building out Great Library Faction

Describe the solution

Library flavored merchant who can buy and sell books

Map tweaks to spawn her and some guards and give the Media building a little bit more definition

Lots of new lore

Guard fixes and improvements

Describe alternatives you've considered

N/A

Testing

Spawns no errors, trading works.

Screenshot 2023-10-08 at 7 30 41 PM

Additional context

Eventually lots of NPCs are intended. Much more map work is needed in future PRs

@github-actions github-actions bot added NPC / Factions NPCs, AI, Speech, Factions, Ownership [JSON] Changes (can be) made in JSON labels Sep 10, 2023
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Sep 10, 2023
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Oct 6, 2023
@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Oct 6, 2023
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Oct 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2023

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • Oh, we did have a President, Mx. Rose. As things were starting to get bad they locked themself into the administrative building with all of the senior staff. It's a good thing too because that building is full of the dead now, just like the rest except the library here. For now everyone is still trying to operate under the old library structure, so I guess I'm in charge now as the seniormost library staff left, though we have some survivors here from the other buildings from other divisions. Callista Rupp from Academics is here, she taught physics. I think she was at MIT for a while. And Jack Springer from Facilities is here too, he's probably the only really practical person here, very handy! It was his idea to board up the other buildings.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Oct 7, 2023
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Oct 8, 2023
@github-actions github-actions bot added the Map / Mapgen Overmap, Mapgen, Map extras, Map display label Oct 8, 2023
@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Oct 8, 2023
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Oct 8, 2023
@LyleSY LyleSY marked this pull request as ready for review October 9, 2023 15:57
@Maleclypse Maleclypse merged commit babe8b6 into CleverRaven:master Oct 12, 2023
36 checks passed
@LyleSY LyleSY deleted the elvira branch October 12, 2023 23:23
detahramet pushed a commit to detahramet/Cataclysm-DDA that referenced this pull request Nov 6, 2023
* Create NPC_Elvira_Fish.json

* remove linting trash

* Create great_library_librarian_goods.json

* rem misc item group

* more accurate desc

* Create great_library_librarian_itemlist.json

* Tools name fix

* tools name fix

* Match caps

* Create great_library_librarian_talk.json

* spaces in places

* First greeting fix

* Create great_library_librarian_talk_fluff.json

* most senior

* space

* spawn Elvira

* fix guard name

* change spawn ids

* fix spawn locations

* Elvira fixes

* fix greeting effect

* Elvira isn't always bald

* Updated goods comments

* Guards have bookbags

* move outside guards outside
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
Development

Successfully merging this pull request may close these issues.

2 participants