Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Found
MININUKE_MOD
andSTREAM_GAS_INSCENTICIDAL
are not used anywhere, jumped in a hole with itpartially adress #67783
Describe the solution
MININUKE_MOD
andSTREAM_GAS_INSCENTICIDAL
as having lack of usageDRAW_LASER_BEAM
and redirect all it's use cases intoLASER
, since they do exactly same thing (spawn fd_laser of intensity 2)magic
withMAGIC
to save consistency between another ammo effectsAmmo Effects
information injson_info.md
to describe all fields that exist in ammo effectsjson_flags.md
, including hardcoded, and moved it toammo_effects.json
, created json definition for all hardcoded ammo effects, and added comment to describe their effect hereTesting
The game opens, hardcoded ammo effects still carry their abilities
Additional context
What is wrong with
RECOVER_
effect scale? even recover 2 grant 50% recoverability, and after 10 it's just beyond 90%, at the level of margin. Why not make it flat percent instead?Like really