Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DinoMod] dino camp hunting #68032

Merged
merged 3 commits into from
Sep 10, 2023
Merged

Conversation

LyleSY
Copy link
Contributor

@LyleSY LyleSY commented Sep 7, 2023

Summary

Mods "[DinoMod] dino camp hunting"

Purpose of change

Feature parity with main game

Describe the solution

Leverages the JSONization from #68014 and customizes those new monster groups with different North American dinos (and compies) that I think make sense for hunting small, trapping, and hunting large. Not including gigantic animals, super dangerous predators, or large dangerous pack animals like triceratops.

Moved some larger corpses to the large group to better match the feel of the vanilla content

Describe alternatives you've considered

Add more kinds of dinos to the large hunting list, but didn't want to overstuff the list. Don't put anything big enough to zombify on the small hunt and trapping lists. Not sure if that's what was intended but what I have is pretty close to that

Testing

Game loads no errors. A camp NPC went trapping several times and brought back a mix of mundane and dino corpses

Screenshot 2023-09-09 at 3 38 34 PM

Additional context

N/A

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Spawn Creatures, items, vehicles, locations appearing on map Mods: Dinomod Anything to do with the Dinoclysm mod (DinoMod) json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Sep 7, 2023
@LyleSY LyleSY marked this pull request as ready for review September 8, 2023 23:53
Copy link
Member

@Maleclypse Maleclypse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes until I know this was your intent so no one merges this if you intended to add dinos instead of making it exclusively dinos.

data/mods/DinoMod/monstergroups/misc.json Show resolved Hide resolved
@LyleSY
Copy link
Contributor Author

LyleSY commented Sep 9, 2023

My intention was to add. I am confused about why some monster groups add smoothly while others overwrite.

@LyleSY LyleSY requested a review from Maleclypse September 9, 2023 13:49
@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Sep 9, 2023
@Maleclypse
Copy link
Member

@RenechCDDA Sorry to ping but is it possible that copy-from isn't needed and monstergroups naturally extend?

@RenechCDDA
Copy link
Member

So, I know I said it overwrites but it seems you're right. After testing, monster groups just... extend instead of overwriting.

That is very weird, and different from the behavior for item groups and other entities. Sorry for the confusion!

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Sep 10, 2023
@Maleclypse Maleclypse merged commit 860f9cb into CleverRaven:master Sep 10, 2023
25 checks passed
@LyleSY LyleSY deleted the camp_hunt_dino branch September 10, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Dinomod Anything to do with the Dinoclysm mod (DinoMod) Mods Issues related to mods or modding Spawn Creatures, items, vehicles, locations appearing on map
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants