-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DinoMod] dino camp hunting #68032
[DinoMod] dino camp hunting #68032
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting changes until I know this was your intent so no one merges this if you intended to add dinos instead of making it exclusively dinos.
My intention was to add. I am confused about why some monster groups add smoothly while others overwrite. |
@RenechCDDA Sorry to ping but is it possible that copy-from isn't needed and monstergroups naturally extend? |
So, I know I said it overwrites but it seems you're right. After testing, monster groups just... extend instead of overwriting. That is very weird, and different from the behavior for item groups and other entities. Sorry for the confusion! |
Summary
Mods "[DinoMod] dino camp hunting"
Purpose of change
Feature parity with main game
Describe the solution
Leverages the JSONization from #68014 and customizes those new monster groups with different North American dinos (and compies) that I think make sense for hunting small, trapping, and hunting large. Not including gigantic animals, super dangerous predators, or large dangerous pack animals like triceratops.
Moved some larger corpses to the large group to better match the feel of the vanilla content
Describe alternatives you've considered
Add more kinds of dinos to the large hunting list, but didn't want to overstuff the list. Don't put anything big enough to zombify on the small hunt and trapping lists. Not sure if that's what was intended but what I have is pretty close to that
Testing
Game loads no errors. A camp NPC went trapping several times and brought back a mix of mundane and dino corpses
Additional context
N/A