-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cordless drills to "power tools" itemgroup, create corded power drills #68021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y in hardware stores.
- modified corded power drill to be able to be used for recipes which also use a cordless power drill in the same capacity - it should appear in itemgroups where cordless power drills may also appear - power tools now have drills, both cordless and corded as appropriate
github-actions
bot
added
[JSON]
Changes (can be) made in JSON
SDL: Tiles / Sound
Tiles visual interface and sounds.
Spawn
Creatures, items, vehicles, locations appearing on map
astyled
astyled PR, label is assigned by github actions
labels
Sep 6, 2023
I will lint the json in the morning. |
github-actions
bot
added
the
json-styled
JSON lint passed, label assigned by github actions
label
Sep 6, 2023
…eds two spaces between sentences). Added a bit more description for the power drill.
Can someone rerun the tests? Thanks. |
github-actions
bot
added
the
BasicBuildPassed
This PR builds correctly, label assigned by github actions
label
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
astyled
astyled PR, label is assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
[JSON]
Changes (can be) made in JSON
json-styled
JSON lint passed, label assigned by github actions
SDL: Tiles / Sound
Tiles visual interface and sounds.
Spawn
Creatures, items, vehicles, locations appearing on map
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Content "Add cordless drills to "power tools" itemgroup and create corded power drills"
Purpose of change
This adds cordless drills to the "power tools" itemgroup, so they will spawn correctly in hardware stores as expected.
This also adds corded drills, as well as to the recipes where they should be in, with the same cost as the cordless cousins.
Describe the solution
This allows cordless drills, a common item, to appear in hardware stores and hardware superstores as might be plausibly expected. This also creates a corded power drill item which functions similarly but without a battery.
Describe alternatives you've considered
Convince myself that cordless drills are not power tools. Submit this PR as a one-line change to add cordless drills to power tools.
Testing
This was tested locally and found to work as expected. Corded power tools also behaved as expected, with functionality enabled only after being plugged in.
Additional context