Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Magiclysm] Add RNG to crystallized mana spawns #67924

Merged

Conversation

Standing-Storm
Copy link
Contributor

@Standing-Storm Standing-Storm commented Aug 27, 2023

Summary

Mods "Add RNG to crystallized mana spawns"

Purpose of change

There's a spell to create crystallized mana, but since crystallized mana spawns didn't have a range defined they all spawned with the max possible mana so you never need to use it.

Describe the solution

Add a range to existing crystallized mana spawns. I set it from 1-10 because the Crystallized Mana spell only produces 1 at a time (5 for manatouched mutants), so there was probably an industrial bottleneck in terms of the number of mages willing to be sleepy 24/7 to churn the stuff out. Smashing big mana crystals still gives you dozens of crystallized mana as before--since that already had a range implemented I didn't change it.

Describe alternatives you've considered

Testing

It works

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Spawn Creatures, items, vehicles, locations appearing on map Mods: Magiclysm Anything to do with the Magiclysm mod labels Aug 27, 2023
@github-actions github-actions bot requested a review from KorGgenT August 27, 2023 21:34
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-requesting reviews from non-collaborators: @GuardianDll

@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Aug 27, 2023
@GuardianDll
Copy link
Member

Actually, with magic wands using 1 crystal per spell, i think original 1 crystal / 5 crystals with manatouched mutation is correct amount, it's just the game spawn is busted. Can you please sane it? Either by decreasing item groups where one spawn or by changing the crystal count or even by removing charges entirely, all approaches would work

@Standing-Storm
Copy link
Contributor Author

I think it has to keep charges since it's an ammo type for the wands, but I could reduce it to 1-10 per spawn point. Does that sound like a reasonable amount?

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Aug 28, 2023
@Rivet-the-Zombie Rivet-the-Zombie merged commit c3cc221 into CleverRaven:master Aug 30, 2023
@Standing-Storm Standing-Storm deleted the fix-crystallized-mana branch August 30, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Magiclysm Anything to do with the Magiclysm mod Mods Issues related to mods or modding Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants