Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distinguish sieving and straining in recipes #67918

Merged
merged 3 commits into from
Sep 2, 2023

Conversation

bowmaster93
Copy link
Contributor

Summary

Infrastructure "Distinguish sieving and straining in recipes"

Purpose of change

Fix #66198
Currently, sieving and straining tools are implemented inconsistently in game; recipes that require such tools define them by item ID, and some recipes are overly specific about the exact tools that they require, making those recipes needlessly more difficult to make use of.

Describe the solution

Define new sieving and straining qualities for use in recipes, add those qualities to items that should have them and modify recipes that previously used respective tools to use the new qualities instead.

Increase spawn rate of steel colander, as proposed in mentioned issue.

Steel mesh recipe was removed, as there seems to be no good way to produce a steel mesh that is thin enough for sieving, by hand. However, cotton patch and wicker sieve can now substitute for it in all recipes, and those can be crafted.

Volume and weight of steel mesh was significantly reduced, as it was previously too large given how this item is used in recipes.

Steel colander, steel sieve and splatter guard can now be disassembled to receive a steel mesh and some scrap metal.

Makeshift sieve, made from some wire and a piece of steel mesh, was implemented as a way to make steel mesh into an usable sieve.

Describe alternatives you've considered

Defining consistent tool lists via requirements instead of using tool qualities.

Testing

Examined the modified recipes in game, checking that they now require newly added qualities, and examined the modified items, checking that they have those qualities.

Additional context

If there is a way to produce a steel mesh that is thin enough for sieving, I could try implementing it.

@github-actions github-actions bot added <Bugfix> This is a fix for a bug (or closes open issue) Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style [JSON] Changes (can be) made in JSON Vehicles Vehicles, parts, mechanics & interactions Items: Food / Vitamins Comestibles and drinks Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Spawn Creatures, items, vehicles, locations appearing on map new contributor astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Aug 27, 2023
@github-actions
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • Some fine steel mesh attached to a length of thicker steel wire, forming a rigid frame. Useful for sieving.
  • sieving

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Aug 29, 2023
@Maleclypse Maleclypse merged commit e25cca1 into CleverRaven:master Sep 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Items: Food / Vitamins Comestibles and drinks [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions new contributor Spawn Creatures, items, vehicles, locations appearing on map Vehicles Vehicles, parts, mechanics & interactions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make mesh colanders craftable.
2 participants