Remove bed requirement for base expansion #67908
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Fix #67889
Fix #67848
Describe the solution
Remove the usage of "bed" tokens as a condition for base camp expansion, and added removal of the order when all potential expansion slots have been used (not to be confused by available slots: there are no checks to weed out slots the base camp can't expand into).
As a bonus, the probably bug behind #67848 was fixed as that was required to test the target change.
Describe alternatives you've considered
N/A
Testing
Additional context
Nothing has been done to individual base camp versions to deal with potential references to bed restrictions.
While doing the changes I also searched the code for all usages of "bed", and the only one found was something associated with vehicles. There were also a couple of checks for "BED", so it's probably safe to remove all allocations of "bed" from base camp recipes, as they should have no usages anymore.