Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Magiclysm] Even more spells (7 spells) #67843

Merged
merged 29 commits into from
Aug 26, 2023

Conversation

Standing-Storm
Copy link
Contributor

@Standing-Storm Standing-Storm commented Aug 23, 2023

Summary

Mods "Even more spells (7 spells)"

Purpose of change

I need to put in more utility spells that aren't Earthshaper/Stormshaper/Druid

Describe the solution

Adds 7 new spells:

  1. Sense Outsiders (Animist): Detect nether creatures in a radius around you
  2. Cloak of Warmth (Kelvinist): Produce hot air and gain a little armor against cold.
  3. Cloak of Chill (Kelvinist): Produce cold air and gain a little armor against heat.
  4. Slowfall (Magus): Greatly reduce falling damage
  5. Spider Climb (Magus): Scale sheer surfaces with ease
  6. Limbs of the Frog (Biomancer): Grow webbed hands and feet to make for easier swimming
  7. Giant Growth (Biomancer): Grow to enormous size to crush your enemies!

Describe alternatives you've considered

Testing

Everything works (though I have one bug report to make). Giant Growth makes you huge and the EoC accounts for your kcal so you don't end up malnourished from casting it, and it does not overwrite or change pre-existing size mutations. Limbs of the Frog does not make the stamina cost of swimming in your clothes lower--that's a vanilla thing, but an out-of-shape character can almost make it across a river after casting it.

Additional context

@Standing-Storm Standing-Storm marked this pull request as draft August 23, 2023 19:22
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Mods: Magiclysm Anything to do with the Magiclysm mod Mechanics: Enchantments / Spells Enchantments and spells labels Aug 23, 2023
@github-actions github-actions bot requested a review from KorGgenT August 23, 2023 19:22
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-requesting reviews from non-collaborators: @GuardianDll

data/mods/Magiclysm/Spells/biomancer.json Outdated Show resolved Hide resolved
data/mods/Magiclysm/Spells/biomancer.json Outdated Show resolved Hide resolved
data/mods/Magiclysm/Spells/biomancer.json Outdated Show resolved Hide resolved
data/mods/Magiclysm/Spells/magus.json Outdated Show resolved Hide resolved
data/mods/Magiclysm/effects/effects.json Outdated Show resolved Hide resolved
data/mods/Magiclysm/effects/effects.json Outdated Show resolved Hide resolved
data/mods/Magiclysm/mutations/temporary.json Outdated Show resolved Hide resolved
Standing-Storm and others added 5 commits August 23, 2023 14:24
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Standing-Storm and others added 2 commits August 23, 2023 14:24
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Aug 23, 2023
@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Aug 24, 2023
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Aug 24, 2023
@github-actions github-actions bot added the Spawn Creatures, items, vehicles, locations appearing on map label Aug 25, 2023
@Standing-Storm Standing-Storm marked this pull request as ready for review August 25, 2023 15:51
@Maleclypse Maleclypse merged commit e5e919f into CleverRaven:master Aug 26, 2023
@Standing-Storm Standing-Storm deleted the even-more-spells branch August 27, 2023 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mechanics: Enchantments / Spells Enchantments and spells Mods: Magiclysm Anything to do with the Magiclysm mod Mods Issues related to mods or modding Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants