Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New characters start with basic life skills #67663

Merged
merged 9 commits into from
Aug 15, 2023

Conversation

Fris0uman
Copy link
Contributor

@Fris0uman Fris0uman commented Aug 14, 2023

Summary

Balance "Characters start with basic skills from their previous life"

Purpose of change

Part of #67580

  • Adds a few backgrounds covering some very common skills most of everyone should start with
  • Make those on by default at the start of char gen

Describe the solution

Describe alternatives you've considered

Testing

  • Start a custom character > the backgrounds are already there
  • Play Now! > character has at least one in all skills they should
  • Play Now! (default scenario) > same
  • Random Character > All the backgrounds are there

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies Game: Balance Balancing of (existing) in-game features. astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Aug 14, 2023
@github-actions
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • You've spent a significant portion of your life living amongs other people here in New England and are familiar with the local social norms. You know how to talk with other people, and how to convey your emotions and understand those of others.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

data/json/hobbies.json Outdated Show resolved Hide resolved
data/json/hobbies.json Outdated Show resolved Hide resolved
data/json/hobbies.json Outdated Show resolved Hide resolved
data/json/hobbies.json Outdated Show resolved Hide resolved
data/json/hobbies.json Outdated Show resolved Hide resolved
Co-authored-by: Antti Riikonen <[email protected]>
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Aug 14, 2023
@github-actions github-actions bot added the [C++] Changes (can be) made in C++. Previously named `Code` label Aug 14, 2023
Copy link
Member

@I-am-Erk I-am-Erk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debatably we could put a few of these together, like adding social to high school graduate. Or driver's license could add driving 1 but so could mundane survival.

data/json/hobbies.json Outdated Show resolved Hide resolved
data/json/hobbies.json Outdated Show resolved Hide resolved
@github-actions github-actions bot added the Character / World Generation Issues and enhancements concerning stages of creating a character or a world label Aug 14, 2023
@Fris0uman Fris0uman marked this pull request as ready for review August 14, 2023 16:43
@Fris0uman
Copy link
Contributor Author

Debatably we could put a few of these together, like adding social to high school graduate. Or driver's license could add driving 1 but so could mundane survival.

I made them modular on purpose so that it's easier to remove the specific thing you don't want. But I can condense them if necessary.

@bombasticSlacks
Copy link
Contributor

You need rules for the translation parser. I believe you can just set it to null for this

@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Aug 14, 2023
@github-actions github-actions bot added the Translation I18n label Aug 14, 2023
@github-actions github-actions bot added the [Python] Code made in Python label Aug 14, 2023
@ampersand55
Copy link
Contributor

If it would take "a day of dedicate work" to reach lvl 1 in a skill (as per #67580), shouldn't there be some sort of point cost for these? Not that 1 skill point is worth 1 point, but perhaps we could make the point system more granular or lump all "normal skills" into one and make that worth 1-2 points, or have "don't know shit" profession without these starting skills that are worth a point or two?

@Fris0uman
Copy link
Contributor Author

Points are going away after next stable, no need to worry about that

@ampersand55
Copy link
Contributor

Won't points still be considered for the "knowledge: average" etc stuff or will they be removed entirely?

@Fris0uman
Copy link
Contributor Author

Pretty sure points are useless. See #64697 for how the new system works

@ampersand55
Copy link
Contributor

Ah, thanks for telling me.

@I-am-Erk
Copy link
Member

If it would take "a day of dedicate work" to reach lvl 1 in a skill (as per #67580), shouldn't there be some sort of point cost for these? Not that 1 skill point is worth 1 point, but perhaps we could make the point system more granular or lump all "normal skills" into one and make that worth 1-2 points, or have "don't know shit" profession without these starting skills that are worth a point or two?

Even regardless, that's a suggestion issue for goals and planning and shouldn't be treated as a design document.

@anoobindisguise
Copy link
Contributor

How will this affect the "knowledge" score? Has that been adjusted? Someone with only these basic life skills should probably still be Weak and not Average (but not Underpowered) since that means they literally just coasted through high school and haven't learned anything beyond the absolute bare minimum.

@I-am-Erk I-am-Erk merged commit 390a4fc into CleverRaven:master Aug 15, 2023
@I-am-Erk
Copy link
Member

I think the char gen screen does need adjusting, but it doesn't need to be in this pr

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Aug 15, 2023
@Fris0uman Fris0uman deleted the life_skills branch August 15, 2023 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Character / World Generation Issues and enhancements concerning stages of creating a character or a world Game: Balance Balancing of (existing) in-game features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies [Python] Code made in Python Translation I18n
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants