Conditional nest predecessor check for subway and trail map unhardcoding #67648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
<Documentation>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
added
json-styled
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions
bot
added
the
astyled
Merged
Procyonae
added a commit
to Procyonae/Cataclysm-DDA
that referenced
this pull request
Oct 4, 2023
…asier (hopefully)
Maleclypse
pushed a commit
that referenced
this pull request
Dec 9, 2023
* Initial JSON stuff * Initial C++ stuff * Making a mess of changing types as per usual * More sensible way * Fixes trailhead rotation and removes obsoleted regional settings * Moves test_regions.json into the test mod * Add width offset accidently 1 too high * Removes obsoleted region_settings documentation * Remembered I'm making the width is purposefully larger for easy mod changes * Adds probably too many items * All repo mod support? * Oblige the clang overlords * Some variants * Linted * Update dictionary.txt * Changes the variants to nests for modding * Rework forest_trail_intersection for new trail * A few more variants * Flag corrections * Correct the merge * Implements #67648 and rejigs the palette to make modding easier (hopefully) * Weight variants * File reorganisation * Minor weight change to bump tests * Changes weights, adds a temp fix for the horse farm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Being able to test for underlying predecessors will allow me to select appropriate nests/foliage for trails in #67470 depending on whether they're in swamp/forest/forest_thick and also help with the way I want to do sub stations with a partial subway unhardcoding I'm doing
Describe the solution
Adds a check in the same vain as the others but that only checks the map itself rather than it's neighbors
Adds documentation
Describe alternatives you've considered
Testing
Checked it worked using some simple nests like this one on road_straight
"place_nested": [ { "chunks": [ "24x24_fence1" ], "x": 0, "y": 0, "predecessors": [ "field" ] } ]Also tested match type ( and that nests still spawn elsewhere >-< )
Additional context