Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change description of "highlighted regions" when editing overmap #67322

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

Golfavel
Copy link
Contributor

Summary

Interface "Change description of highlighted regions when editing the overmap"

Purpose of change

Fixes I-am-Erk/CDDA-Tilesets#1983

Describe the solution

Edited description to be more broad in regards to how the highlight appears visually.

Describe alternatives you've considered

Not doing this as it is a debug-only bit of text.
Adding support for a tileset to define what color the highlight is for the description to refer to.
Sampling the sprite used for the highlighting to determine what color it is and referring to the most dominant color.

Testing

highlightedregions

Additional context

@github-actions github-actions bot added Info / User Interface Game - player communication, menus, etc. Map / Mapgen Overmap, Mapgen, Map extras, Map display [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jul 31, 2023
@Maleclypse Maleclypse merged commit a619f82 into CleverRaven:master Jul 31, 2023
@Golfavel Golfavel deleted the om_hil branch August 1, 2023 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc. json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overmap tiles flash different color than debug menu states.
2 participants