Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPC reads books repeatedly #67301

Merged
merged 10 commits into from
Aug 1, 2023

Conversation

lispcoc
Copy link
Contributor

@lispcoc lispcoc commented Jul 30, 2023

Summary

Features "NPC reads books repeatedly"

Purpose of change

NPC learns from books. But we have to assign task for each book.

Describe the solution

NPC reads books he has repeatedly.

Describe alternatives you've considered

Testing

Game begin. Assign task to read books. NPC reads books he has in order.

Additional context

There will be need to find books in zones in future. But NPC zone activity is buggy currently. (#64799) I will implement after this issue is fixed.

@github-actions github-actions bot added NPC / Factions NPCs, AI, Speech, Factions, Ownership [JSON] Changes (can be) made in JSON [C++] Changes (can be) made in C++. Previously named `Code` <Enhancement / Feature> New features, or enhancements on existing labels Jul 30, 2023
src/npctalk.cpp Outdated Show resolved Hide resolved
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Jul 30, 2023
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jul 30, 2023
@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jul 31, 2023
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jul 31, 2023
@lispcoc lispcoc marked this pull request as ready for review July 31, 2023 09:33
@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jul 31, 2023
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Aug 1, 2023
@Rivet-the-Zombie Rivet-the-Zombie merged commit b4c5469 into CleverRaven:master Aug 1, 2023
@lispcoc lispcoc deleted the npc_multiple_read branch August 1, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` <Enhancement / Feature> New features, or enhancements on existing [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants