Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concrete Mixer audit #67047

Merged
merged 26 commits into from
Apr 4, 2024
Merged

Concrete Mixer audit #67047

merged 26 commits into from
Apr 4, 2024

Conversation

Karol1223
Copy link
Contributor

@Karol1223 Karol1223 commented Jul 20, 2023

Summary

None

Purpose of change

Our tiny tabletop concrete mixer didn't really fit with realism that well

Describe the solution

CONCRETE MIXER ITEM CHANGES
  • Weight increased from ~9kg to ~41kg
  • Volume increased from 5l to 250l
  • Added a manually defined longest side of 118cm
  • Decreased pre-apo price from 500$ to 400$
  • to-hit values now use modifiers
  • Material now has 50% plastic (based on a concrete mixer with a plastic drum)
  • Added an open pocket that can be used to store things
  • Removed the HOTPLATE use action because why the fuck can we heat up lunch in a concrete mixer
  • Made it an unfoldable vehicle and added a pseudotool - it now can only be used when unfolded into vehicle form
CONCRETE MIXER RECIPE CHANGES
  • No longer takes raw steel, 2l metal tank, or heating elements
  • Will now take 2 small wheels and a 30 gallon plastic barrel
  • Tripled the number of pipes needed
  • No longer has metalworking proficiency
  • Will now take an extension cord instead of a bunch of loose cables
  • Will take a small motor instead of a tiny motor
  • Added some nuts and bolts as per the user manual of the one I'm basing this off
  • Added some small metal sheets (for the blades to mix the concrete as well as to cover the motor)
  • The weld length has been recalculated and increased over four times
  • Now needs a metal sawing quality of 2 instead of 1, multitool won't cut it
30 GALLON PLASTIC BARREL CHANGES
  • Volume increased from ~118l to ~165l
  • Pocket volume increased slightly (by ~1l)
  • Added a manually defined longest side of 72cm
  • Increased pre-apo price from 50$ to 71$
  • Renamed to clearly show it's made of plastic
  • to-hit values now use modifiers
  • Recipe fundamentally changed to be melding the plastic barrel instead of duct-taping plastic jerrycans together (?)
MISC CHANGES
  • Concrete mixer can no longer be attached to the modular rigs (vehicle & appliance)

Describe alternatives you've considered

Testing

Although most of the things work as expected, the PR is blocked by #71108
No longer blocked

Additional context

The recipe isn't perfect and generates roughly 7kg of mass, but I cannot make it better without adding bullshit requirements.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions Spawn Creatures, items, vehicles, locations appearing on map BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jul 20, 2023
@anoobindisguise
Copy link
Contributor

I wouldn't get rid of the battery or modular rig compatibility. It's good to keep options for usage open, that's why microwaves, hotplates, welders etc can run on battery backup.
Have you made sure it doesn't cause overflow iin the world due to 1000L space limits?

@Karol1223
Copy link
Contributor Author

Karol1223 commented Jul 20, 2023

I wouldn't get rid of the battery or modular rig compatibility. It's good to keep options for usage open, that's why microwaves, hotplates, welders etc can run on battery backup. Have you made sure it doesn't cause overflow iin the world due to 1000L space limits?

I've not made sure of anything yet, really. Hence the testing disclaimer. I'm not sure how to test it either but we'll burn that bridge when we get there.

As for the first part - I disagree. I am a firm believer in realism. And, frankly, if you're using a concrete mixer for anything the least you can do is have a power grid set up. Again, this warrants further testing and if it doesn't work as intended I'll give it the battery magazine back BUT if it does work as intended I do want to have it function only plugged in. It makes NO sense for a concrete mixer to take batteries.

Besides, I want to test the waters specifically to see how viable items that function only off the grid are. If this works I wanna try some other stuff like table lamps or possibly swapping the microwaves you mentioned to not take batteries anymore either. But that's an issue for future me.

@github-actions github-actions bot added the Crafting / Construction / Recipes Includes: Uncrafting / Disassembling label Jul 23, 2023
@github-actions github-actions bot added the Items: Containers Things that hold other things label Jul 27, 2023
@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@github-actions github-actions bot added the stale Closed for lack of activity, but still valid. label Aug 31, 2023
@Karol1223
Copy link
Contributor Author

Alright so to highlight what's actually going on with this one - I am stumped at how to handle the crafting recipe so that it doesn't generate mass. That's what's been blocking me from finishing this. As it stands, the crafting recipe generates roughly 30kg of mass if memory serves me right. But it uses accurate ingredients. So where's the issue? Good question! I'd like to know too...

@github-actions github-actions bot removed the stale Closed for lack of activity, but still valid. label Sep 1, 2023
@Karol1223 Karol1223 mentioned this pull request Sep 2, 2023
@Kanexan
Copy link
Contributor

Kanexan commented Sep 21, 2023

There are some cordless battery-powered concrete mixers, but they're going to be the kind that is an agitating rod on a handle citation here. These would work by putting your concrete components in a container such as a drum or bucket, and then mixing it within there; all of the stereotypical rotating-drum concrete mixers are going to be either powered by electric cord or by gasoline. We probably should also have gasoline-powered concrete mixers, but battery powered mixers of the type we have in game simply do not exist in any meaningful quantity.

@Karol1223
Copy link
Contributor Author

There are some cordless battery-powered concrete mixers, but they're going to be the kind that is an agitating rod on a handle citation here. These would work by putting your concrete components in a container such as a drum or bucket, and then mixing it within there; all of the stereotypical rotating-drum concrete mixers are going to be either powered by electric cord or by gasoline. We probably should also have gasoline-powered concrete mixers, but battery powered mixers of the type we have in game simply do not exist in any meaningful quantity.

I'm gonna be making that an appliance so no gasoline powering for that.

@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions and removed json-styled JSON lint passed, label assigned by github actions labels Oct 22, 2023
@github-actions
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • A plastoc 100-liter drum of a portable concrete mixer.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Oct 22, 2023
@Karol1223 Karol1223 closed this Oct 22, 2023
@Karol1223 Karol1223 reopened this Oct 22, 2023
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Oct 22, 2023
@Karol1223 Karol1223 marked this pull request as ready for review March 30, 2024 17:34
@Karol1223 Karol1223 closed this Mar 30, 2024
@Karol1223 Karol1223 reopened this Mar 30, 2024
@I-am-Erk I-am-Erk merged commit a6604d0 into CleverRaven:master Apr 4, 2024
36 of 49 checks passed
@GuardianDll GuardianDll deleted the konk-kreet branch April 4, 2024 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Items: Containers Things that hold other things [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants