Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update claw bar volume to be consistent with crowbar #66765

Merged
merged 5 commits into from
Jul 9, 2023

Conversation

ampersand55
Copy link
Contributor

@ampersand55 ampersand55 commented Jul 8, 2023

Summary

Balance "Update claw bar volume to be consistent with crowbar"

Purpose of change

A claw bar is basically a smaller crowbar, so it should have less volume, but it currently has a volume of 350 ml (which makes it not fit into a tactical tool pouch) compared to the crowbar which has a volume of 100 ml. This currently makes it completely useless.

Describe the solution

This sets claw bar volume to 64 ml, 64 % of the crow bar, which is the same proportion as the weight.

Describe alternatives you've considered

Testing

None, just linted as it only changes a number in json.

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Jul 8, 2023
@github-actions github-actions bot added Code: Tests Measurement, self-control, statistics, balancing. Game: Balance Balancing of (existing) in-game features. labels Jul 9, 2023
@Karol1223
Copy link
Contributor

Karol1223 commented Jul 9, 2023

Tbh I am willing to bet money that it's because the crowbar's volume is fucked. 100ml for a crowbar seems ungodly low.

Also when the DPS tests fail, you alter the weapon's damage values. Not the tests. That's not how this works.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jul 9, 2023
@ampersand55
Copy link
Contributor Author

I reverted the test change and decreased the damage to match the test.

I don't know how volume is considered. Steel has a density of 8kg/l and as they are L-shaped you can fit them snugly in a corner of a box-shaped storage space and not take up much room.

Heavy crow bar has the same density of 5.5, and makeshift crowbar has a density of 4.5, but Halligan bar has a density exceeding that of steel (4.77 kg/0.55 l = 8.67 kg/l) and should probably have its volume increased. Heavy crow bar should probably also have prying 4 similar to a Halligan bar as it's 1.5 meters long. Perhaps even a reach-attack.

But those changes are beyond the scope of this PR.

@Karol1223
Copy link
Contributor

But those changes are beyond the scope of this PR.

You're right. I'll take a look at crowbars sometime soon and audit their numbers to be based on actual real-world items but until now this is an okay compromise.

@Maleclypse Maleclypse merged commit 6fac4ab into CleverRaven:master Jul 9, 2023
@ampersand55 ampersand55 deleted the update_clawbar branch August 22, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Code: Tests Measurement, self-control, statistics, balancing. Game: Balance Balancing of (existing) in-game features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants