-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MELEE_DAMAGE and ITEM_DAMAGE_BASH enchantments should affect bashing damage to tile #66735
MELEE_DAMAGE and ITEM_DAMAGE_BASH enchantments should affect bashing damage to tile #66735
Conversation
Strength doesn't influence it? I thought it add points to your character strength, which affect the bash output? |
I'll remove the STRENGTH enchantment calculation I added since STRENGTH enchantments will affect
Good point on ITEM_DAMAGE_BASH, I'll add that as well. |
…y ITEM_DAMAGE_BASH
…n, not just when player is wielding weapon
…into 66434/enchantment_tile_bash
Summary
Bugfixes "Smashing now incorporates any MELEE_DAMAGE and STRENGTH enchantments"
Purpose of change
#66434. STRENGTH and ITEM_DAMAGE_BASH enchantments should influence SMASH capabilities but currently only takes in arm_strength and the weapon's bash damage.
Describe the solution
Use
calculate_by_enchantment
to help contribute to the amount of smash damage done.Describe alternatives you've considered
I initially thought about just linearly adding the STRENGTH and MELEE_DAMAGE bonuses to the smash damage, but I figured that
calculate_by_enchantment
was better suited to handle the smash damage calculation.Testing
Terrorize senior citizensSmash reinforced glass until it breaks.Reinforced glass has a bash_min of 40 and a pipe_mace has a bash rating of 24, so casting TACTILE KINESIS should allow the player to smash the window with a STRENGTH of 4
Additional context