Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grab cleanup #66732

Merged
merged 4 commits into from
Jul 10, 2023
Merged

Grab cleanup #66732

merged 4 commits into from
Jul 10, 2023

Conversation

bombasticSlacks
Copy link
Contributor

Summary

None

Purpose of change

The JSON for grabs seemed a little prone to failure and didn't really provide any direct utility so moved some stuff to track just in the engine.

Describe the solution

added accessors for grabs,
added a list for grabbed limbs to track

Describe alternatives you've considered

Testing

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Code: Tests Measurement, self-control, statistics, balancing. [C++] Changes (can be) made in C++. Previously named `Code` Melee Melee weapons, tactics, techniques, reach attack Limbs Limbs, mutable limbs, and code related to them. json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Jul 7, 2023
@github-actions github-actions bot added Mods Issues related to mods or modding Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies Mods: Xedra Evolved Anything to do with Xedra Evolved labels Jul 7, 2023
@github-actions github-actions bot requested a review from Maleclypse July 7, 2023 18:39
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-requesting reviews from non-collaborators: @GuardianDll

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jul 8, 2023
@dseguin dseguin merged commit 50471ec into CleverRaven:master Jul 10, 2023
@bombasticSlacks bombasticSlacks deleted the monster-goodies branch July 13, 2023 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Code: Tests Measurement, self-control, statistics, balancing. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Limbs Limbs, mutable limbs, and code related to them. Melee Melee weapons, tactics, techniques, reach attack Mods: Xedra Evolved Anything to do with Xedra Evolved Mods Issues related to mods or modding Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants