Remove redundant json in vehicleparts/doors.json and vehicleparts/vehicle_parts.json #66525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```
DEBUG : (json-error)
Json error: data/json/vehicleparts/doors.json:106:16: cannot assign explicit value the same as default or inherited value
"description": "A strong door. Solid construction means you can't see through it when closed.",
"durability": 660,
"location":
^
"center",
"looks_like": "door_opaque",
"name": { "str": "heavy-duty opaque door" },
FUNCTION : void report_strict_violation(const JsonObject&, const string&, std::string_view)
FILE : src/assign.cpp
LINE : 11
VERSION : 5820766
```
Ref: CleverRaven#66450
Default from veh_type.h:
```
nc_color color = c_light_gray;
```
Error:
```
DEBUG : (json-error)
Json error: data/json/vehicleparts/vehicle_parts.json:2,198:13: cannot assign explicit value the same as default or inherited value
"variants": [ { "symbols": "+", "symbols_broken": "&" } ],
"categories": [ "hull" ],
"color":
^
"light_gray",
"looks_like": "door_trunk",
"broken_color": "light_gray",
FUNCTION : void report_strict_violation(const JsonObject&, const string&, std::string_view)
FILE : src/assign.cpp
LINE : 11
VERSION : 5820766
```
Default from veh_type.h:
```
nc_color color_broken = c_light_gray;
```
Error:
```
DEBUG : (json-error)
Json error: data/json/vehicleparts/vehicle_parts.json:2,200:20: cannot assign explicit value the same as default or inherited value
"color": "light_gray",
"looks_like": "door_trunk",
"broken_color":
^
"light_gray",
"damage_modifier": 80,
"durability": 750,
FUNCTION : void report_strict_violation(const JsonObject&, const string&, std::string_view)
FILE : src/assign.cpp
LINE : 11
VERSION : 5820766
```
Default from veh_type.h: ``` nc_color color_broken = c_light_gray; ```
github-actions
bot
added
[JSON]
|
Oops. Dupe #66523 |
github-actions
bot
added
the
BasicBuildPassed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
It appears that #66450 forgot to remove some redundant json entries. This was causing debug warnings.
Describe the solution
Remove redundant
location,colorandbroken_colorTesting
The game loads successfully