recruiting static NPCs makes them lose their static traits

[Daved27hundred]

Summary

None

Purpose of change

The NPC traits "ignore sounds" and "will not bash" were not set to be invisible in the traits menu, meaning NPCs with them that could be recruited (Meteorologist mostly) would display them if you asked to know about them.

Describe the solution

added player_display: false to both traits Maleclypse suggested I have the NPCs lose said traits once they're recruited.

[Maleclypse]

The correct fix for this would be to remove those traits when the character becomes a follower. This would break things further by making follower NPCs have weird behaviour that is impossible to easily identify. Those two traits break followers regularly. Sorry :(

[Maleclypse]

Do not merge as is.

[Daved27hundred]

Understood, what do you suggest I do instead?

[Maleclypse]

"success": {
          "topic": "TALK_AGREE_FOLLOW",
          "effect": "follow",
          "opinion": { "trust": 1, "value": 1 },
          "npc_lose_trait": [ "RETURN_TO_START_POS", "NO_BASH", "IGNORE_SOUND" ]
        },

Update the meteorologist follow dialogue to include the npc_lose_trait line. Same for any other characters that have any of those three traits. Make sure to only remove the traits they already have.

[Daved27hundred]

got it - I'll start this tomorrow, it's quite late.

[Daved27hundred]

@Maleclypse Is this where it should go? I'm not very familiar with NPC code. Can't find the TALK_AGREE_FOLLOW line in here so I think I might be in the wrong place. (npcs/other/meteorologist.json)

[Maleclypse]

Ah ha. So you're going to want to go to TALK_COMMON_OTHER.json and then any effect that includes follow your going to want to add "npc_lose_trait": [ "RETURN_TO_START_POS", "NO_BASH", "IGNORE_SOUND" ] apparently I didn't realize when I did the first one that the different reasons to persuade an npc to follow you used different talk topics. Which I should have. Sorry

[Daved27hundred]

Should I remove the player_display: false lines I added?

[Maleclypse]

Should I remove the player_display: false lines I added?

Yes please. That way if other people add new follows we'll know something has gone wrong.

edit: Maybe even write in some "if you see this trait here's where things have gone wrong"?