-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the Hi-Point 3895, a .380 ACP PCC #66373
Merged
bombasticSlacks
merged 15 commits into
CleverRaven:master
from
anoobindisguise:anoobindisguise-hpt3895
Jun 23, 2023
Merged
Add the Hi-Point 3895, a .380 ACP PCC #66373
bombasticSlacks
merged 15 commits into
CleverRaven:master
from
anoobindisguise:anoobindisguise-hpt3895
Jun 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions
bot
added
[JSON]
Changes (can be) made in JSON
Items: Ammo / Guns
Ammunition for all kinds of weapons and these weapons themselves
Items: Magazines
Ammo holding items and objects.
Spawn
Creatures, items, vehicles, locations appearing on map
labels
Jun 22, 2023
Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details. Click to expand
This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to |
github-actions
bot
added
json-styled
JSON lint passed, label assigned by github actions
astyled
astyled PR, label is assigned by github actions
labels
Jun 22, 2023
github-actions
bot
added
Mods
Issues related to mods or modding
Mods: Generic Guns
Anything to do with Generic Guns
labels
Jun 22, 2023
github-actions
bot
added
the
BasicBuildPassed
This PR builds correctly, label assigned by github actions
label
Jun 22, 2023
Co-authored-by: TheShadowFerret <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
astyled
astyled PR, label is assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
Items: Ammo / Guns
Ammunition for all kinds of weapons and these weapons themselves
Items: Magazines
Ammo holding items and objects.
[JSON]
Changes (can be) made in JSON
json-styled
JSON lint passed, label assigned by github actions
Mods: Generic Guns
Anything to do with Generic Guns
Mods
Issues related to mods or modding
Spawn
Creatures, items, vehicles, locations appearing on map
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Content "add .380 ACP carbine"
Purpose of change
I want more PCCs. Bigger damage number give me the good brain chemical.
Describe the solution
Adds the aforementioned gun. It is fairly rare but shows up anywhere standard guns can be found. Its magazine is not compatible with the Hi-Point CF380 pistol magazine. It gets +2 damage, this is per the muzzle velocity of a 95g bullet found in https://rangehot.com/380-auto-pistol-vs-carbine/ compared to that of a standard round. Other stuff is mostly based on manufacturer's specs. Volume of the gun is a guess based on scaling up a regular hi-point CF380 pistol to the new length/weight, which means it might be wrong. Dispersion and range bonus are based on the Cx4 Storm (9mm has 14 range and Cx4 gives +20 range. 380 has 13 range so I gave the 3895 +17 range. Regular 9mm has 480 dispersion but the Cx4 has 180, so since regular 380 also has 480 dispersion I gave the 3895 180 dispersion)
Describe alternatives you've considered
Give it +3 damage. It's pretty close and would round up but my assumption is that we floor all fractional bullet damages.
Testing
Loaded up in game and took some screenies. No errors.
Additional context