Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workshop 2 palettization #66353

Merged

Conversation

PatrikLundell
Copy link
Contributor

Summary

None

Purpose of change

Palettize workshop expansion verison 2 to reduce the size of the JSON footprint.

Describe the solution

Essentially copy-paste-modify the same pattern as has been used for other expansions, i.e. make use of palette parameters instead of separate recipes for different construction materials.

Describe alternatives you've considered

Don't fix what ain't broken.

Testing

Constructed the buildings out of each material in a separate expansion slot (restarting each time as the base save uses basecamp version 1, which is bed restricted) and verifying that it looks as expected.
The first one also had all the interiors built (those recipes were not touched), but as the game crashed when trying to build a salt water pipe (#66318) I didn't get a chance to walk over and inspect the results, and couldn't be bothered to redo it as those recipes were unchanged and I didn't see anything off from what could be seen from the bulletin board.

Additional context

Added flag to accept items under the constructions and cleaned up palette names (2_2 -> 2).

@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Map / Mapgen Overmap, Mapgen, Map extras, Map display BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jun 21, 2023
@Maleclypse Maleclypse merged commit fdfd598 into CleverRaven:master Jun 21, 2023
@PatrikLundell PatrikLundell deleted the workshop_2_palettization branch June 22, 2023 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Crafting / Construction / Recipes Includes: Uncrafting / Disassembling [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants