Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Will this fix the mutable? The answer may surprise you! #66312

Merged
merged 3 commits into from
Jun 23, 2023

Conversation

LovamKicsiGazsii
Copy link
Contributor

Summary

None

Purpose of change

I don't know if this fixes #65983.

Describe the solution

The mutable was having some trouble when three tentacles wanted to end at the same spot. So I added a "tentacle tee" at the end of the generation line to hopefully fix that. I made the chances of it spawning rare enough to spawn only when it's absolutely necessary.

Describe alternatives you've considered

Fourway connections are not accounted for, but I imagine it is magnitudes rarer than the already mythical three-way connection so I'm not too worried.

Testing

Fast-scrolled through Overmap for ~5 minutes. No errors. Not that it means anything.

Additional context

None.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Jun 19, 2023
@RenechCDDA
Copy link
Member

I'm running local tests (currently 8 passes....) on a similar implementation right now, I think you may need to change the connection rules for tentacle_tee as well to avoid errors when tees are adjacent to tees.

I used this:

      "tentacle_tee": {
        "overmap": "corpse_tentacle_nes",
        "north": { "id": "tentacle_to_tentacle", "alternatives": [ "tentacle_tee_to_tentacle" ] },
        "east": { "id": "tentacle_tee_to_tentacle", "alternatives": [ "tentacle_to_tentacle" ] },
        "south": { "id": "tentacle_tee_to_tentacle", "alternatives": [ "tentacle_to_tentacle" ] }
      },

Of course it failed right as I was typing this.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jun 19, 2023
@RenechCDDA
Copy link
Member

Failed locally on tests.

Output(with the same added debug messages for nearby terrain):

Output 06:54:58.734 INFO : Starting the actual test at Mon Jun 19 06:54:58 2023 Filters: overmap_terrain_coverage

06:55:43.203 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (136,156,-1) with ID solid_earth
06:55:43.203 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (137,156,-1) with ID corpse_tentacle_ew
06:55:43.204 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (137,157,-1) with ID solid_earth
06:55:43.204 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (136,157,-1) with ID corpse_tentacle_ns
06:55:43.205 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (135,157,-1) with ID solid_earth
06:55:43.206 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (135,156,-1) with ID solid_earth
06:55:43.207 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (135,155,-1) with ID solid_earth
06:55:43.207 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (136,155,-1) with ID corpse_tentacle_es
06:55:43.208 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (137,155,-1) with ID corpse_tentacle_wn
06:55:43.209 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (138,155,-1) with ID corpse_bowels_rcorner_south
06:55:43.210 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (138,156,-1) with ID corpse_bowels_tentacle_edge_west
06:55:43.210 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (138,157,-1) with ID corpse_bowels_empty_edge_east
06:55:43.211 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (138,158,-1) with ID corpse_bowels_tentacle_edge_west
06:55:43.212 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (137,158,-1) with ID corpse_tentacle_ew
06:55:43.213 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (136,158,-1) with ID corpse_tentacle_ne
06:55:43.213 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (135,158,-1) with ID solid_earth
06:55:43.214 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (134,158,-1) with ID solid_earth
06:55:43.215 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (134,157,-1) with ID solid_earth
06:55:43.216 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (134,156,-1) with ID solid_earth
06:55:43.216 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (134,155,-1) with ID solid_earth
06:55:43.217 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (134,154,-1) with ID solid_earth
06:55:43.218 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (135,154,-1) with ID solid_earth
06:55:43.219 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (136,154,-1) with ID solid_earth
06:55:43.219 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (137,154,-1) with ID corpse_tentacle_es
06:55:43.220 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (138,154,-1) with ID corpse_tentacle_wn
06:55:43.222 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (139,154,-1) with ID corpse_tentacle_ns
06:55:43.223 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (139,155,-1) with ID corpse_bowels_tentacle_edge_north
06:55:43.224 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (139,156,-1) with ID corpse_bowels_mid
06:55:43.224 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (139,157,-1) with ID corpse_bowels_mid
06:55:43.225 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (139,158,-1) with ID corpse_bowels_mid
06:55:43.226 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (139,159,-1) with ID corpse_bowels_empty_edge_north
06:55:43.228 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (138,159,-1) with ID corpse_bowels_lcorner_north
06:55:43.229 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (137,159,-1) with ID solid_earth
06:55:43.230 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (136,159,-1) with ID solid_earth
06:55:43.230 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (135,159,-1) with ID solid_earth
06:55:43.231 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (134,159,-1) with ID solid_earth
06:55:43.232 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (133,159,-1) with ID solid_earth
06:55:43.233 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (133,158,-1) with ID solid_earth
06:55:43.233 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (133,157,-1) with ID solid_earth
06:55:43.234 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (133,156,-1) with ID solid_earth
06:55:43.235 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (133,155,-1) with ID solid_earth
06:55:43.236 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (133,154,-1) with ID solid_earth
06:55:43.236 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (133,153,-1) with ID solid_earth
06:55:43.238 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (134,153,-1) with ID solid_earth
06:55:43.239 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (135,153,-1) with ID solid_earth
06:55:43.240 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (136,153,-1) with ID solid_earth
06:55:43.241 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (137,153,-1) with ID solid_earth
06:55:43.241 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (138,153,-1) with ID corpse_tentacle_es
06:55:43.242 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (139,153,-1) with ID corpse_tentacle_sw
06:55:43.243 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (140,153,-1) with ID solid_earth
06:55:43.244 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (140,154,-1) with ID solid_earth
06:55:43.244 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (140,155,-1) with ID corpse_bowels_empty_edge_south
06:55:43.245 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (140,156,-1) with ID corpse_bowels_mid
06:55:43.246 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (140,157,-1) with ID corpse_bowels_mid
06:55:43.247 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (140,158,-1) with ID corpse_bowels_mid
06:55:43.247 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (140,159,-1) with ID corpse_bowels_tentacle_edge_south
06:55:43.248 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (140,160,-1) with ID corpse_tentacle_ns
06:55:43.249 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (139,160,-1) with ID solid_earth
06:55:43.249 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (138,160,-1) with ID solid_earth
06:55:43.250 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (137,160,-1) with ID solid_earth
06:55:43.251 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (136,160,-1) with ID solid_earth
06:55:43.252 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (135,160,-1) with ID solid_earth
06:55:43.253 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (134,160,-1) with ID solid_earth
06:55:43.254 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (133,160,-1) with ID solid_earth
06:55:43.255 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (132,160,-1) with ID solid_earth
06:55:43.256 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (132,159,-1) with ID solid_earth
06:55:43.257 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (132,158,-1) with ID solid_earth
06:55:43.257 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (132,157,-1) with ID solid_earth
06:55:43.258 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (132,156,-1) with ID solid_earth
06:55:43.259 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (132,155,-1) with ID solid_earth
06:55:43.260 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (132,154,-1) with ID solid_earth
06:55:43.260 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (132,153,-1) with ID solid_earth
06:55:43.261 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (132,152,-1) with ID solid_earth
06:55:43.262 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (133,152,-1) with ID solid_earth
06:55:43.262 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (134,152,-1) with ID solid_earth
06:55:43.263 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (135,152,-1) with ID solid_earth
06:55:43.264 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (136,152,-1) with ID solid_earth
06:55:43.265 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (137,152,-1) with ID solid_earth
06:55:43.265 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (138,152,-1) with ID solid_earth
06:55:43.266 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (139,152,-1) with ID solid_earth
06:55:43.267 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (140,152,-1) with ID solid_earth
06:55:43.268 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (141,152,-1) with ID solid_earth
06:55:43.270 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (141,153,-1) with ID corpse_tentacle_es
06:55:43.270 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (141,154,-1) with ID corpse_tentacle_ns
06:55:43.271 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (141,155,-1) with ID corpse_bowels_tentacle_edge_north
06:55:43.272 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (141,156,-1) with ID corpse_bowels_mid
06:55:43.273 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (141,157,-1) with ID corpse_bowels_mid
06:55:43.273 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (141,158,-1) with ID corpse_bowels_mid
06:55:43.274 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (141,159,-1) with ID corpse_bowels_empty_edge_north
06:55:43.275 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (141,160,-1) with ID solid_earth
06:55:43.275 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (141,161,-1) with ID solid_earth
06:55:43.276 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (140,161,-1) with ID corpse_tentacle_ns
06:55:43.277 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (139,161,-1) with ID corpse_tentacle_entry_south
06:55:43.278 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (138,161,-1) with ID solid_earth
06:55:43.278 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (137,161,-1) with ID solid_earth
06:55:43.279 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (136,161,-1) with ID solid_earth
06:55:43.280 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (135,161,-1) with ID solid_earth
06:55:43.281 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (134,161,-1) with ID solid_earth
06:55:43.281 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (133,161,-1) with ID solid_earth
06:55:43.282 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (132,161,-1) with ID solid_earth
06:55:43.283 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (131,161,-1) with ID solid_earth
06:55:43.285 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (131,160,-1) with ID solid_earth
06:55:43.285 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (131,159,-1) with ID solid_earth
06:55:43.286 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (131,158,-1) with ID solid_earth
06:55:43.287 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (131,157,-1) with ID solid_earth
06:55:43.288 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (131,156,-1) with ID solid_earth
06:55:43.288 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (131,155,-1) with ID solid_earth
06:55:43.289 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (131,154,-1) with ID solid_earth
06:55:43.290 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (131,153,-1) with ID solid_earth
06:55:43.291 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (131,152,-1) with ID solid_earth
06:55:43.291 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (131,151,-1) with ID solid_earth
06:55:43.292 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (132,151,-1) with ID solid_earth
06:55:43.293 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (133,151,-1) with ID solid_earth
06:55:43.294 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (134,151,-1) with ID solid_earth
06:55:43.294 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (135,151,-1) with ID solid_earth
06:55:43.295 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (136,151,-1) with ID solid_earth
06:55:43.296 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (137,151,-1) with ID solid_earth
06:55:43.297 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (138,151,-1) with ID solid_earth
06:55:43.297 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (139,151,-1) with ID solid_earth
06:55:43.298 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (140,151,-1) with ID solid_earth
06:55:43.299 ERROR : \Cataclysm-DDA\src\overmap.cpp:2554 [place] SURROUNDING TERRAIN WAS: (141,151,-1) with ID solid_earth
06:55:43.300 ERROR : \Cataclysm-DDA\src\overmap.cpp:2560 [place] Spawn of mutable special nether_monster_corpse had unresolved joins. Existing terrain at (136,156,-1) was solid_earth; joins were north: tentacle_to_tentacle, east: tentacle_to_tentacle, and south: tentacle_to_tentacle
Complete record of placement follows:
At (140,157,-1) FAILED to match on terrain solid_earth with neighbours N:solid_earth E:solid_earth S:solid_earth W:solid_earth and constraints above: surface_to_bowels from amongst rules surface

Entering phase 1

At (140,157,-1) chose 'bowels' rot 3 with neighbours N:solid_earth E:solid_earth S:solid_earth W:solid_earth and constraints above: surface_to_bowels

Entering phase 2

At (140,156,-1) chose 'bowels_edge1' rot 2 with neighbours N:solid_earth E:corpse_bowels_mid S:corpse_bowels_mid W:corpse_bowels_mid and constraints south: bowels_mid_to_mid
At (139,154,-1) FAILED to match on terrain solid_earth with neighbours N:solid_earth E:solid_earth S:corpse_bowels_tentacle_edge_north W:solid_earth and constraints south: bowels_tentacle_to_edge from amongst rules bowels_edge1 and bowels_edge2
At (141,154,-1) FAILED to match on terrain solid_earth with neighbours N:solid_earth E:solid_earth S:corpse_bowels_tentacle_edge_north W:solid_earth and constraints south: bowels_tentacle_to_edge from amongst rules bowels_edge1 and bowels_edge2
At (140,158,-1) chose 'bowels_edge2' rot 0 with neighbours N:corpse_bowels_mid E:corpse_bowels_mid S:solid_earth W:corpse_bowels_mid and constraints north: bowels_mid_to_mid
At (140,160,-1) FAILED to match on terrain solid_earth with neighbours N:corpse_bowels_tentacle_edge_south E:solid_earth S:solid_earth W:solid_earth and constraints north: bowels_tentacle_to_edge from amongst rules bowels_edge1 and bowels_edge2
At (139,157,-1) chose 'bowels_edge1' rot 1 with neighbours N:corpse_bowels_mid E:corpse_bowels_mid S:corpse_bowels_mid W:solid_earth and constraints east: bowels_mid_to_mid
At (137,156,-1) FAILED to match on terrain solid_earth with neighbours N:solid_earth E:corpse_bowels_tentacle_edge_west S:solid_earth W:solid_earth and constraints east: bowels_tentacle_to_edge from amongst rules bowels_edge1 and bowels_edge2
At (137,158,-1) FAILED to match on terrain solid_earth with neighbours N:solid_earth E:corpse_bowels_tentacle_edge_west S:solid_earth W:solid_earth and constraints east: bowels_tentacle_to_edge from amongst rules bowels_edge1 and bowels_edge2
At (143,157,-1) FAILED to match on terrain solid_earth with neighbours N:solid_earth E:solid_earth S:solid_earth W:corpse_bowels_neck_edge_center_east and constraints west: neck_to_neck from amongst rules bowels_edge1 and bowels_edge2

Entering phase 3

At (137,158,-1) FAILED to match on terrain solid_earth with neighbours N:solid_earth E:corpse_bowels_tentacle_edge_west S:solid_earth W:solid_earth and constraints east: bowels_tentacle_to_edge from amongst rules neck_3x1
At (141,154,-1) FAILED to match on terrain solid_earth with neighbours N:solid_earth E:solid_earth S:corpse_bowels_tentacle_edge_north W:solid_earth and constraints south: bowels_tentacle_to_edge from amongst rules neck_3x1
At (140,160,-1) FAILED to match on terrain solid_earth with neighbours N:corpse_bowels_tentacle_edge_south E:solid_earth S:solid_earth W:solid_earth and constraints north: bowels_tentacle_to_edge from amongst rules neck_3x1
At (137,156,-1) FAILED to match on terrain solid_earth with neighbours N:solid_earth E:corpse_bowels_tentacle_edge_west S:solid_earth W:solid_earth and constraints east: bowels_tentacle_to_edge from amongst rules neck_3x1
At (139,154,-1) FAILED to match on terrain solid_earth with neighbours N:solid_earth E:solid_earth S:corpse_bowels_tentacle_edge_north W:solid_earth and constraints south: bowels_tentacle_to_edge from amongst rules neck_3x1
At (143,157,-1) chose 'neck_3x1' rot 3 with neighbours N:solid_earth E:solid_earth S:solid_earth W:corpse_bowels_neck_edge_center_east and constraints west: neck_to_neck

Entering phase 4

At (140,160,-1) FAILED to match on terrain solid_earth with neighbours N:corpse_bowels_tentacle_edge_south E:solid_earth S:solid_earth W:solid_earth and constraints north: bowels_tentacle_to_edge from amongst rules neck_3x1_extra
At (139,154,-1) FAILED to match on terrain solid_earth with neighbours N:solid_earth E:solid_earth S:corpse_bowels_tentacle_edge_north W:solid_earth and constraints south: bowels_tentacle_to_edge from amongst rules neck_3x1_extra
At (137,158,-1) FAILED to match on terrain solid_earth with neighbours N:solid_earth E:corpse_bowels_tentacle_edge_west S:solid_earth W:solid_earth and constraints east: bowels_tentacle_to_edge from amongst rules neck_3x1_extra
At (137,156,-1) FAILED to match on terrain solid_earth with neighbours N:solid_earth E:corpse_bowels_tentacle_edge_west S:solid_earth W:solid_earth and constraints east: bowels_tentacle_to_edge from amongst rules neck_3x1_extra
At (141,154,-1) FAILED to match on terrain solid_earth with neighbours N:solid_earth E:solid_earth S:corpse_bowels_tentacle_edge_north W:solid_earth and constraints south: bowels_tentacle_to_edge from amongst rules neck_3x1_extra
At (144,157,-1) chose 'neck_3x1_extra' rot 1 with neighbours N:solid_earth E:solid_earth S:solid_earth W:corpse_neck_center_west and constraints west: neck_to_neck

Entering phase 5

At (139,154,-1) FAILED to match on terrain solid_earth with neighbours N:solid_earth E:solid_earth S:corpse_bowels_tentacle_edge_north W:solid_earth and constraints south: bowels_tentacle_to_edge from amongst rules head_intact and head_decapicated
At (137,158,-1) FAILED to match on terrain solid_earth with neighbours N:solid_earth E:corpse_bowels_tentacle_edge_west S:solid_earth W:solid_earth and constraints east: bowels_tentacle_to_edge from amongst rules head_intact and head_decapicated
At (141,154,-1) FAILED to match on terrain solid_earth with neighbours N:solid_earth E:solid_earth S:corpse_bowels_tentacle_edge_north W:solid_earth and constraints south: bowels_tentacle_to_edge from amongst rules head_intact and head_decapicated
At (137,156,-1) FAILED to match on terrain solid_earth with neighbours N:solid_earth E:corpse_bowels_tentacle_edge_west S:solid_earth W:solid_earth and constraints east: bowels_tentacle_to_edge from amongst rules head_intact and head_decapicated
At (140,160,-1) FAILED to match on terrain solid_earth with neighbours N:corpse_bowels_tentacle_edge_south E:solid_earth S:solid_earth W:solid_earth and constraints north: bowels_tentacle_to_edge from amongst rules head_intact and head_decapicated
At (145,157,-1) chose 'head_intact' rot 3 with neighbours N:solid_earth E:solid_earth S:solid_earth W:corpse_neck_center_east and constraints west: neck_to_neck

Entering phase 6

At (137,158,-1) chose 'tentacle_mid' rot 1 with neighbours N:solid_earth E:corpse_bowels_tentacle_edge_west S:solid_earth W:solid_earth and constraints east: bowels_tentacle_to_edge
At (141,154,-1) chose 'tentacle_mid' rot 2 with neighbours N:solid_earth E:solid_earth S:corpse_bowels_tentacle_edge_north W:solid_earth and constraints south: bowels_tentacle_to_edge
At (139,154,-1) chose 'tentacle_mid' rot 2 with neighbours N:solid_earth E:solid_earth S:corpse_bowels_tentacle_edge_north W:solid_earth and constraints south: bowels_tentacle_to_edge
At (140,160,-1) chose 'tentacle_mid' rot 0 with neighbours N:corpse_bowels_tentacle_edge_south E:solid_earth S:solid_earth W:solid_earth and constraints north: bowels_tentacle_to_edge
At (137,156,-1) chose 'tentacle_mid' rot 1 with neighbours N:solid_earth E:corpse_bowels_tentacle_edge_west S:solid_earth W:solid_earth and constraints east: bowels_tentacle_to_edge

Entering phase 7

At (139,153,-1) chose 'tentacle_rcorner' rot 3 with neighbours N:solid_earth E:solid_earth S:corpse_tentacle_ns W:solid_earth and constraints south: tentacle_to_tentacle
At (138,153,-1) chose 'tentacle_rcorner' rot 2 with neighbours N:solid_earth E:corpse_tentacle_sw S:solid_earth W:solid_earth and constraints east: tentacle_to_tentacle
At (141,153,-1) chose 'tentacle_corner' rot 1 with neighbours N:solid_earth E:solid_earth S:corpse_tentacle_ns W:solid_earth and constraints south: tentacle_to_tentacle
At (140,161,-1) chose 'tentacle_mid' rot 0 with neighbours N:corpse_tentacle_ns E:solid_earth S:solid_earth W:solid_earth and constraints north: tentacle_to_tentacle
At (136,158,-1) chose 'tentacle_corner' rot 0 with neighbours N:solid_earth E:corpse_tentacle_ew S:solid_earth W:solid_earth and constraints east: tentacle_to_tentacle
At (138,154,-1) chose 'tentacle_corner' rot 3 with neighbours N:corpse_tentacle_es E:corpse_tentacle_ns S:corpse_bowels_rcorner_south W:solid_earth and constraints north: tentacle_to_tentacle
At (137,154,-1) chose 'tentacle_rcorner' rot 2 with neighbours N:solid_earth E:corpse_tentacle_wn S:solid_earth W:solid_earth and constraints east: tentacle_to_tentacle
At (142,153,-1) chose 'tentacle_mid' rot 3 with neighbours N:solid_earth E:solid_earth S:solid_earth W:corpse_tentacle_es and constraints west: tentacle_to_tentacle
At (140,162,-1) chose 'tentacle_rcorner' rot 1 with neighbours N:corpse_tentacle_ns E:solid_earth S:solid_earth W:solid_earth and constraints north: tentacle_to_tentacle
At (143,153,-1) chose 'tentacle_rcorner' rot 3 with neighbours N:solid_earth E:solid_earth S:solid_earth W:corpse_tentacle_ew and constraints west: tentacle_to_tentacle
At (136,157,-1) chose 'tentacle_mid' rot 0 with neighbours N:solid_earth E:solid_earth S:corpse_tentacle_ne W:solid_earth and constraints south: tentacle_to_tentacle
At (137,155,-1) chose 'tentacle_corner' rot 3 with neighbours N:corpse_tentacle_es E:corpse_bowels_rcorner_south S:corpse_tentacle_ew W:solid_earth and constraints north: tentacle_to_tentacle
At (141,162,-1) chose 'tentacle_corner' rot 2 with neighbours N:solid_earth E:solid_earth S:solid_earth W:corpse_tentacle_ne and constraints west: tentacle_to_tentacle
At (141,163,-1) chose 'tentacle_mid' rot 0 with neighbours N:corpse_tentacle_sw E:solid_earth S:solid_earth W:solid_earth and constraints north: tentacle_to_tentacle
At (136,155,-1) chose 'tentacle_corner' rot 1 with neighbours N:solid_earth E:corpse_tentacle_wn S:solid_earth W:solid_earth and constraints east: tentacle_to_tentacle
At (136,156,-1) FAILED to match on terrain solid_earth with neighbours N:corpse_tentacle_es E:corpse_tentacle_ew S:corpse_tentacle_ns W:solid_earth and constraints north: tentacle_to_tentacle, east: tentacle_to_tentacle, and south: tentacle_to_tentacle from amongst rules tentacle_corner, tentacle_rcorner, and tentacle_mid
At (143,154,-1) chose 'tentacle_mid' rot 0 with neighbours N:corpse_tentacle_sw E:solid_earth S:solid_earth W:solid_earth and constraints north: tentacle_to_tentacle
At (143,155,-1) chose 'tentacle_rcorner' rot 1 with neighbours N:corpse_tentacle_ns E:solid_earth S:corpse_neck_west W:corpse_bowels_rcorner_west and constraints north: tentacle_to_tentacle
At (144,155,-1) chose 'tentacle_rcorner' rot 0 with neighbours N:solid_earth E:solid_earth S:corpse_neck_east W:corpse_tentacle_ne and constraints west: tentacle_to_tentacle
At (144,154,-1) chose 'tentacle_corner' rot 1 with neighbours N:solid_earth E:solid_earth S:corpse_tentacle_wn W:corpse_tentacle_ns and constraints south: tentacle_to_tentacle
At (145,154,-1) chose 'tentacle_rcorner' rot 0 with neighbours N:solid_earth E:solid_earth S:solid_earth W:corpse_tentacle_es and constraints west: tentacle_to_tentacle
At (145,153,-1) chose 'tentacle_corner' rot 1 with neighbours N:solid_earth E:solid_earth S:corpse_tentacle_wn W:solid_earth and constraints south: tentacle_to_tentacle
At (141,164,-1) chose 'tentacle_mid' rot 2 with neighbours N:corpse_tentacle_ns E:solid_earth S:solid_earth W:solid_earth and constraints north: tentacle_to_tentacle
At (146,153,-1) chose 'tentacle_corner' rot 2 with neighbours N:solid_earth E:solid_earth S:solid_earth W:corpse_tentacle_es and constraints west: tentacle_to_tentacle
At (146,154,-1) chose 'tentacle_corner' rot 0 with neighbours N:corpse_tentacle_sw E:solid_earth S:corpse_head_rcorner_south W:corpse_tentacle_wn and constraints north: tentacle_to_tentacle
At (141,165,-1) chose 'tentacle_rcorner' rot 0 with neighbours N:corpse_tentacle_ns E:solid_earth S:solid_earth W:solid_earth and constraints north: tentacle_to_tentacle
At (140,165,-1) chose 'tentacle_mid' rot 3 with neighbours N:solid_earth E:corpse_tentacle_wn S:solid_earth W:solid_earth and constraints east: tentacle_to_tentacle
At (139,165,-1) chose 'tentacle_corner' rot 0 with neighbours N:solid_earth E:corpse_tentacle_ew S:solid_earth W:solid_earth and constraints east: tentacle_to_tentacle
At (139,164,-1) chose 'tentacle_rcorner' rot 2 with neighbours N:solid_earth E:solid_earth S:corpse_tentacle_ne W:solid_earth and constraints south: tentacle_to_tentacle
At (140,164,-1) chose 'tentacle_corner' rot 3 with neighbours N:solid_earth E:corpse_tentacle_ns S:corpse_tentacle_ew W:corpse_tentacle_es and constraints west: tentacle_to_tentacle
At (140,163,-1) chose 'tentacle_rcorner' rot 3 with neighbours N:corpse_tentacle_ne E:corpse_tentacle_ns S:corpse_tentacle_wn W:solid_earth and constraints south: tentacle_to_tentacle
At (139,163,-1) chose 'tentacle_rcorner' rot 1 with neighbours N:solid_earth E:corpse_tentacle_sw S:corpse_tentacle_es W:solid_earth and constraints east: tentacle_to_tentacle

Entering phase 8

At (136,156,-1) FAILED to match on terrain solid_earth with neighbours N:corpse_tentacle_es E:corpse_tentacle_ew S:corpse_tentacle_ns W:solid_earth and constraints north: tentacle_to_tentacle, east: tentacle_to_tentacle, and south: tentacle_to_tentacle from amongst rules tentacle_mid
At (139,162,-1) chose 'tentacle_mid' rot 0 with neighbours N:solid_earth E:corpse_tentacle_ne S:corpse_tentacle_ne W:solid_earth and constraints south: tentacle_to_tentacle
At (147,154,-1) chose 'tentacle_mid' rot 1 with neighbours N:solid_earth E:solid_earth S:corpse_head_edge_south W:corpse_tentacle_ne and constraints west: tentacle_to_tentacle
At (148,154,-1) chose 'tentacle_mid' rot 3 with neighbours N:solid_earth E:solid_earth S:corpse_head_rcorner_west W:corpse_tentacle_ew and constraints west: tentacle_to_tentacle
At (149,154,-1) chose 'tentacle_mid' rot 3 with neighbours N:solid_earth E:solid_earth S:solid_earth W:corpse_tentacle_ew and constraints west: tentacle_to_tentacle

Entering phase 9

At (136,156,-1) FAILED to match on terrain solid_earth with neighbours N:corpse_tentacle_es E:corpse_tentacle_ew S:corpse_tentacle_ns W:solid_earth and constraints north: tentacle_to_tentacle, east: tentacle_to_tentacle, and south: tentacle_to_tentacle from amongst rules tentacle_end_w_entry
At (150,154,-1) chose 'tentacle_end_w_entry' rot 3 with neighbours N:solid_earth E:solid_earth S:solid_earth W:corpse_tentacle_ew and constraints west: tentacle_to_tentacle

Entering phase 10

At (150,154,0) FAILED to match on terrain forest_thick with neighbours N:forest_thick E:forest_thick S:forest_thick W:forest_thick and constraints below: surface_to_tentacle from amongst rules tentacle_end_w_entry
At (136,156,-1) FAILED to match on terrain solid_earth with neighbours N:corpse_tentacle_es E:corpse_tentacle_ew S:corpse_tentacle_ns W:solid_earth and constraints north: tentacle_to_tentacle, east: tentacle_to_tentacle, and south: tentacle_to_tentacle from amongst rules tentacle_end_w_entry
At (139,161,-1) chose 'tentacle_end_w_entry' rot 2 with neighbours N:solid_earth E:corpse_tentacle_ns S:corpse_tentacle_ns W:solid_earth and constraints south: tentacle_to_tentacle

Entering phase 11

At (139,161,0) chose 'corpse_entry_surface' rot 3 with neighbours N:field E:forest S:forest W:forest and constraints below: surface_to_tentacle
At (150,154,0) chose 'corpse_entry_surface' rot 1 with neighbours N:forest_thick E:forest_thick S:forest_thick W:forest_thick and constraints below: surface_to_tentacle
At (136,156,-1) FAILED to match on terrain solid_earth with neighbours N:corpse_tentacle_es E:corpse_tentacle_ew S:corpse_tentacle_ns W:solid_earth and constraints north: tentacle_to_tentacle, east: tentacle_to_tentacle, and south: tentacle_to_tentacle from amongst rules corpse_entry_surface

Entering phase 12

At (136,156,-1) FAILED to match on terrain solid_earth with neighbours N:corpse_tentacle_es E:corpse_tentacle_ew S:corpse_tentacle_ns W:solid_earth and constraints north: tentacle_to_tentacle, east: tentacle_to_tentacle, and south: tentacle_to_tentacle from amongst rules tentacle_end, tentacle_tee, tentacle_end_lcorner, and tentacle_end_straight===============================================================================
All tests passed (1 assertion in 1 test case)

06:56:03.062 INFO : Ended test at Mon Jun 19 06:56:03 2023

06:56:03.063 INFO : The test took 64.3275 seconds
06:56:03.064 INFO : Treating result as failure due to error logged during tests.

@github-actions github-actions bot removed json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jun 22, 2023
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jun 22, 2023
@LovamKicsiGazsii
Copy link
Contributor Author

I'm running local tests (currently 8 passes....) on a similar implementation right now, I think you may need to change the connection rules for tentacle_tee as well to avoid errors when tees are adjacent to tees.

I used this:

      "tentacle_tee": {
        "overmap": "corpse_tentacle_nes",
        "north": { "id": "tentacle_to_tentacle", "alternatives": [ "tentacle_tee_to_tentacle" ] },
        "east": { "id": "tentacle_tee_to_tentacle", "alternatives": [ "tentacle_to_tentacle" ] },
        "south": { "id": "tentacle_tee_to_tentacle", "alternatives": [ "tentacle_to_tentacle" ] }
      },

Of course it failed right as I was typing this.

I decided to go one step further and deleted "tentacle_tee_to_tentacle" and its opposites altogether. I also tried testing the flexibility of the generation and bumped the tentacle tees to spawn 10000x as often. It worked without issues.

This passes the checks for now, so here's a hesitant yay! from me. God, mutables are such a headache!

@dseguin dseguin merged commit 6e134a1 into CleverRaven:master Jun 23, 2023
@LovamKicsiGazsii LovamKicsiGazsii deleted the speedway branch August 7, 2023 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mutable Huge Corpse Mapgen failures
3 participants