Pipe rifle update: Three new calibers & recipe nesting #66125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[JSON]
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
added
astyled
TheShadowFerret
force-pushed
the
PipeNested
branch
from
5dae97c to
ab31e82
Compare
github-actions
bot
added
the
BasicBuildPassed
|
Should the .44 pipe rifle actually continue to exist? .44 is nearing rifle levels of pressure, right? |
|
Perhaps 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Content "More pipe rifles, and nesting"
Purpose of change
.32 ACP, .380 ACP & 9x18 are all low chamber pressure(for barrel made from pipe, see #40912 (comment)) pistol cartridges without a pipe rifle variant.
All the pipe rifles are unnested despite all following the same naming convention & crafting tools/components.
Describe the solution
Add pipe rifle versions, nest all "pipe rifle: [cartridge]"s together.
Describe alternatives you've considered
No .380 version, and adding it an as alternate cartridge for the 9x19 pipe rifle due to being the same diameter cartridge & cycling potentially failing from the lower power being irrelevant in a single-shot.
Testing