Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework and expand NRE data recordings #65957

Merged
merged 3 commits into from
Jun 7, 2023

Conversation

John-Candlebury
Copy link
Member

@John-Candlebury John-Candlebury commented Jun 1, 2023

Summary

Features "Rework and expand NRE data recordings"

Purpose of change

Quell some gameplay antipatterns involving NRE data recording and expand the ways in which data can be collected.

Describe the solution

Noticed that players were making exploit adjacent setups to collect portal storm data at nearly no risk whatsoever. This limits the efficacy of such things by limiting the amount of short and normal length NRE printouts Hub 01 will accept (to 3 and 15 respectively, may still be too many?). Hub will still accept an infinite number of long printouts.

To compensate, I've made it so certain interactions can also create "anomaly data", that Hub will also buy indefinitely. Mostly you get those by killing notable nether monster or by interacting with the portal dungeon, with some more spoiler adjacent interactions also giving data.

Additionally the NRE recorder now indicates what type of portal storm data it has stored through warning beeps, so its easier to track what kind of printout you'll receive.

Testing

Collected both anomaly and portal storm data normally. Traded them with hub 01

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` [JSON] Changes (can be) made in JSON EOC: Effects On Condition Anything concerning Effects On Condition <Enhancement / Feature> New features, or enhancements on existing json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Jun 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2023

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • A long sequence of overlapping numbers plotted in thermal paper, at times so densely-packed that they disappear into thick blots of oxide-colored ink. The printed values increased along rhythmical waves, but the humber 5 is always skipped.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jun 1, 2023
@Fris0uman Fris0uman merged commit ec7537a into CleverRaven:master Jun 7, 2023
@John-Candlebury John-Candlebury deleted the NRE-EVENTS branch June 7, 2023 22:20
@kholat
Copy link
Contributor

kholat commented Jun 11, 2023

you get a ton of anomaly printouts from just doing the dungeon which is basically 0 risk now (only seems to spawn 1 pale reflection) i got like 35 and each sells for 10 hub gold coins, which are 50 barter value each at 17500 total barter value seems insane for some "walking around in a weird dungeon for a few mins"

@John-Candlebury
Copy link
Member Author

Well I cant imagine the dungeon being that easy is intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` <Enhancement / Feature> New features, or enhancements on existing EOC: Effects On Condition Anything concerning Effects On Condition [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants