Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix CI test failures on library mapgen #65945

Merged
merged 1 commit into from
May 31, 2023

Conversation

Maleclypse
Copy link
Member

Summary

None

Purpose of change

Bugfix test failures.

(continued from above) ERROR : src/map.cpp:1662 [bool map::furn_set(const tripoint &, const furn_id &, const bool, bool)] Setting furniture f_water_heater at (16,17,1) where terrain is t_open_air (which is_open_air)
([slow] ~starting_items)=> If this is intentional, set the ALLOW_ON_OPEN_AIR flag on the furniture
([slow] ~starting_items)=> 01:22:08.477 ERROR : src/mapgen.cpp:2766 [virtual void jmapgen_furniture::apply(const mapgendata &, const jmapgen_int &, const jmapgen_int &, const std::string &) const] Problem setting furniture in nested mapgen roof_6x6_utility in mapgen s_library_roof_3
([slow] ~starting_items)=> 01:22:08.477 ERROR : src/map.cpp:1662 [bool map::furn_set(const tripoint &, const furn_id &, const bool, bool)] Setting furniture f_water_heater at (17,17,1) where terrain is t_open_air (which is_open_air)
([slow] ~starting_items)=> If this is intentional, set the ALLOW_ON_OPEN_AIR flag on the furniture
([slow] ~starting_items)=> 01:22:08.477 ERROR : src/mapgen.cpp:2766 [virtual void jmapgen_furniture::apply(const mapgendata &, const jmapgen_int &, const jmapgen_int &, const std::string &) const] Problem setting furniture in nested mapgen roof_6x6_utility in mapgen s_library_roof_3
([slow] ~starting_items)=> 01:22:08.477 ERROR : src/map.cpp:1662 [bool map::furn_set(const tripoint &, const furn_id &, const bool, bool)] Setting furniture f_water_purifier at (18,17,1) where terrain is t_open_air (which is_open_air)
([slow] ~starting_items)=> If this is intentional, set the ALLOW_ON_OPEN_AIR flag on the furniture
([slow] ~starting_items)=> 01:22:08.477 ERROR : src/mapgen.cpp:2766 [virtual void jmapgen_furniture::apply(const mapgendata &, const jmapgen_int &, const jmapgen_int &, const std::string &) const] Problem setting furniture in nested mapgen roof_6x6_utility in mapgen s_library_roof_3217.484 s: overmap_terrain_coverage

Describe the solution

Trying to fix the above error.

Describe alternatives you've considered

leaving for others

Testing

CI and hope it's better

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels May 31, 2023
@Maleclypse Maleclypse changed the title Update library.json Attempt to fix CI test failures on library mapgen May 31, 2023
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label May 31, 2023
@dseguin dseguin merged commit daeb01c into CleverRaven:master May 31, 2023
@Maleclypse Maleclypse deleted the Library-rooftop-variant-fix branch May 31, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants