Rework wallet pocket restrictions #65937
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Magiclysm's denarii coins don't fit into the coin purse pocket of wallets, but
"pocket_data"
's"item_restriction"
can't be extended and having to overwrite all wallet pockets in a mod sounds like a giant headache for mod compatibility in the future.Describe the solution
*_SHAPED
flags for bank notes & straps, coins and (credit) cards"flag_restriction"
sDescribe alternatives you've considered
I thought about using volume/length restrictions instead, but I got a headache trying to figure out a way to handle bank notes, credit cards and coins since all of them are so much thinner than long.
Testing
Additional context
rubik_farthing
) now fits into coin purse pockets (and cash registers) since it's a coincondom
's pocket to circumvent the pocket restrictions, but you could do that before these changes already...survnote
is nowBANK_NOTE_SHAPED
since it spawns incash_register
but doesn't make sense asBANK_NOTE_STRAP_SHAPED
... there's probably a bunch of other note stuff that could fit in the same pockets, but that's out of scope for this PR since I'm just trying to keep pocket parity as much as possiblecash_register
used to allow the various money bundles, but since all of them are too big (1.13 l volume vs 1.00 l pocket), I just dropped them from thecash_register
(instead of adding aBANK_NOTE_BUNDLE_SHAPED
flag)FMCNote
no longer also fits into the coin purse since it's based on a $50 billid_artisan_member
now fits into the card slots which it didn't beforeid_science
(like the colored ones of the TCL) now fit into wallet card slots, not just the lanyard, since they are the same shape as the normal ID cardcoin_wrapper
since that is explicitly for the specific USD coin denominations