Enable clang-tidy cert-dcl58-cpp #65784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re-enable this check and suppress the false-positives it was producing. The issue regarding these false-positives can be found at llvm/llvm-project#45454 Once that is fixed these suppressions can be removed.
github-actions
bot
added
[C++]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Static analysis.
This check looks for inappropriately adding to
namespace std.Describe the solution
Re-enable this check and suppress the false-positives it was producing.
Also refactor some of the template specializations now that I've learnt a better way to write them (without explicitly opening
namespace std).The issue regarding these false-positives can be found here. Once that is fixed these suppressions can be removed.
Describe alternatives you've considered
Leaving this check disabled until the bug is fixed.
Testing
Run clang-tidy.
Additional context