Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: reduce fireproof doorways #65659

Merged
merged 1 commit into from
May 16, 2023
Merged

fix: reduce fireproof doorways #65659

merged 1 commit into from
May 16, 2023

Conversation

casswedson
Copy link
Contributor

Summary

None

Purpose of change

fix: #65012

add FLAMMABLE_ASH to a bunch of door frames, that makes them flammable right? I didn't test but it makes sense

all the door frames affected give planks and the like so this is OK

Describe the solution

Describe alternatives you've considered

Testing

Additional context

@casswedson
fix: reduce fireproof doorways
d60e6b6 
add `FLAMMABLE_ASH` to a buch of door frames, that makes them flammable
right? I didn't test but it makes sense

all the door frames affected give planks and the like so this is OK
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. <Bugfix> This is a fix for a bug (or closes open issue) json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels May 15, 2023
Maleclypse
Maleclypse approved these changes May 16, 2023
View reviewed changes
Copy link
Member

@Maleclypse Maleclypse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label May 16, 2023
@dseguin dseguin merged commit c69662c into CleverRaven:master May 16, 2023
@casswedson casswedson deleted the fix-fireproof-doorways branch May 16, 2023 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Maleclypse Maleclypse Maleclypse approved these changes

Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Empty Doorways Fireproof?
3 participants
@casswedson @Maleclypse @dseguin