Standalone fault_fix object

[irwiss]

Summary

None

Purpose of change

Work towards #64528

Describe the solution

72a8af6 Makes fault_fix (previously mending_method) a standalone json object with it's own loader. Also slightly changes schema: skills are now a dictionary, this should allow cleaner copy-from if needed and less complex json.

dd5cbc9 Merges the existing fault_fix duplicates for dirt and blackpowder cleaning / lubrication now that fixes are separate from faults.

4f17b95 Moves hardcoded (faulty) prefixes into json definition of the fault

Describe alternatives you've considered

Testing

Most user facing changes should be string changes; (faulty) is now defined per-fault, so gun with a fault_gun_chamber_spent will display jammed instead of faulty, salvaged bionics will display salvaged, blackpowder fouled guns will display rusting etc

The layout of fault mending changed slightly as fault_fix now can add/remove multiple faults, unused so invisible yet but also a UI change: there's label for fault_fix modifying damage

Spawn lightly damaged cars until you get some engine faults, should be able to mend them if the requirements are fulfilled

Spawn 2 5.56 guns and some blackpowder ammo, load one with BP ammo, shoot both, see that the correct faults were added (one should have bp fouling, other normal fouling), mend both guns - see both guns lose their correspponding fouling fault

Additional context

[github-actions]

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand

• unlubricated

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

[ama0]

Maybe it's better to change the json filenames from faults_xyz.json to xyz_faults.json in data/json/faults/. Just to make it easier to navigate all the files, because there probably will be a lot of files in this folder. And I think it's more intuitive 😅

faults_xyz	xyz_faults
faults_bar	bar_faults
faults_baz	bar_fixes
faults_bionics	baz_faults
faults_foo	baz_fixes
faults_guns	bionics_faults
faults_vehicles	bionics_fixes
fixes_bar	foo_faults
fixes_baz	foo_fixes
fixes_bionics	guns_faults
fixes_foo	guns_fixes
fixes_guns	vehicle_faults
fixes_vehicles	vehicle_fixes

[irwiss]

I don't expect a lot of files, or at least not a lot of sense to split more than per kind of fault, so worst case ~20 files in total

[Fris0uman]

Don't this need some documentation to explain how to write a fault object?

[irwiss]

Yep forgot about those, seems docs didn't exist even for previous fault definitions either, added some