Add longest_side to bullets
#65184
Merged
Add longest_side to bullets
#65184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
json-styled
github-actions
bot
removed
the
json-styled
GuardianDll
commented
Apr 19, 2023
github-actions
bot
added
the
json-styled
github-actions
bot
added
Items: Armor / Clothing
katemonster33
pushed a commit
to katemonster33/Cataclysm-DDA
that referenced
this pull request
May 17, 2023
* initial commit * Add length to 50 bmg ammo box, so 50 bmg can fit here * Update data/json/items/containers/military.json * Update military.json * Please work please work please work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Doing some stuff, i found a need to calculate the length of the bullets, and found the game has lack of bullet length for almost all rounds. As i will use this info anyway, i decide to fix it also, as it may cause some issues, when charges went away
Describe the solution
Simply add
longest_sideto most bullet in the game - only 1 change per file, as bullets copy-from each otherThe omitted bullet lengths are paper cartridges, some heavy stuff (as they have it already) and caseless rounds