Add no damage message for ranged weakpoint hits #65183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[C++]
irwiss
reviewed
Apr 19, 2023
Co-authored-by: Alexey <[email protected]>
github-actions
bot
added
the
BasicBuildPassed
|
There's a double "the" in the example screenshot. |
Whoops thanks for catching that |
katemonster33
pushed a commit
to katemonster33/Cataclysm-DDA
that referenced
this pull request
May 17, 2023
* Update creature.cpp * Update creature.cpp * Update src/creature.cpp Co-authored-by: Alexey <[email protected]> * Update creature.cpp --------- Co-authored-by: Alexey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Interface "Adds a message that details no damage hits against weakpoints with ranged weapons."
Purpose of change
To provide additional context for players when a shot fails to do damage to a monster especially when using low-powered weapons/rounds(eg. slings or .22) or when hitting strongpoints.
Describe the solution
Expanded the no damage line to check if a weakpoint is being hit and if so to display the appropriate message.
Describe alternatives you've considered
I had some trouble with phrasing to make it work with how weakpoints are named. I think what I got works but I'm down to change it if better or more desirable phrasing is conceived.
Testing
Spawned in a variety of armored monsters then shot them with .22 at various skill levels then checked the log to make sure the messages displayed. Had several monsters and npcs shoot other armored monsters (mostly the Titan Stag Beetle) as well. Also shot some unarmored monsters to make sure I didn't break anything.
Additional context