Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc Comestible Fixes #65071

Merged
merged 5 commits into from
Apr 14, 2023
Merged

Conversation

Karol1223
Copy link
Contributor

@Karol1223 Karol1223 commented Apr 14, 2023

Summary

None

Purpose of change

There were several problems with comestibles that were brought to my attention. I also wanted to add salt as a new material to hopefully fix some densities. It seemed a bit much for the typical item fixes I do so it went into a separate branch.

Describe the solution

PEANUTBUTTER
  • Was given junk and nut as its material with a 50/50 proportion because I'm not a chef
  • This should also affect the panutbutter spread and the imitation peanutbutter - making them properly problematic for carnivore mutants
SALT & SALT WATER
  • Added a new salt material
  • The new material was applied to salt, seasoned salt, rock salt and salt water - lets hope this fixes some densities
SWEET WATER
  • Now has junk as part of its material to (hopefully) fix the density and represent the sugar used
  • The density may still be broken because the laws of physics blur around food recipes
  • Weight increased 260g -> 300g - the recipe uses 50g of sugar
COOKING OIL
  • Both types got 2x increase in commonality in pantries and seafood restaurants, 2.5x increase in normal restaurants
DEHYDRATED LOBSTER
  • Will now spawn in paper wrappers instead of laying loose in the pantries

Describe alternatives you've considered

Testing

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Items: Food / Vitamins Comestibles and drinks Spawn Creatures, items, vehicles, locations appearing on map json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Apr 14, 2023
@mqrause
Copy link
Contributor

mqrause commented Apr 14, 2023

SWEET WATER
* Volume increased 250ml -> 265ml

I don't think that's a good change considering pretty much all liquid containers are multiples of 250ml.

@Karol1223
Copy link
Contributor Author

SWEET WATER

  • Volume increased 250ml -> 265ml

I don't think that's a good change considering pretty much all liquid containers are multiples of 250ml.

I just realized - it's less than 'not good'. This will break it spawning in the default container... I'll revert it to 250, the problem here is that the density is going to implode... But I'll be lying if I was to say that I have a solution.

@github-actions github-actions bot added the Code: Tests Measurement, self-control, statistics, balancing. label Apr 14, 2023
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Apr 14, 2023
@Karol1223 Karol1223 marked this pull request as draft April 14, 2023 13:52
@Karol1223 Karol1223 marked this pull request as ready for review April 14, 2023 14:26
@bombasticSlacks bombasticSlacks merged commit 39fb637 into CleverRaven:master Apr 14, 2023
@Karol1223 Karol1223 deleted the misc-comestibles branch April 19, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Code: Tests Measurement, self-control, statistics, balancing. Items: Food / Vitamins Comestibles and drinks [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants