Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix spell copy from #64839

Merged
merged 1 commit into from
Apr 7, 2023
Merged

Fix spell copy from #64839

merged 1 commit into from
Apr 7, 2023

Conversation

Ramza13
Copy link
Contributor

@Ramza13 Ramza13 commented Apr 4, 2023 •
edited
Loading

Summary

None

Purpose of change

Fixes #64673
Fixes #64738
Fixes #64824

Describe the solution

Copy from wasn't being handled after switching away from using optional so add handling.

Describe alternatives you've considered

Testing

Additional context

@Ramza13 Ramza13 requested a review from KorGgenT as a code owner April 4, 2023 23:44
@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` <Bugfix> This is a fix for a bug (or closes open issue) json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Apr 4, 2023
@GuardianDll
Copy link
Member

Also fixes #64738 and #64824

@Drew4484 Drew4484 mentioned this pull request Apr 6, 2023
Merged
12 tasks
@dseguin dseguin merged commit 328d8d0 into CleverRaven:master Apr 7, 2023
@Ramza13 Ramza13 deleted the fix-copy-from-spells branch April 7, 2023 21:38
@Night-Pryanik Night-Pryanik mentioned this pull request Apr 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KorGgenT KorGgenT Awaiting requested review from KorGgenT

Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Milestone
No milestone
3 participants
@Ramza13 @GuardianDll @dseguin