Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preparation for upgrading to clang-tidy 16 #64694

Merged
merged 5 commits into from
Mar 31, 2023
Merged

Preparation for upgrading to clang-tidy 16 #64694

merged 5 commits into from
Mar 31, 2023

Conversation

BrettDong
Copy link
Member

Summary

None

Purpose of change

Make the code compliant with some of the newly added checks after LLVM 12.

Describe the solution

I put code changes for appeasing each check in separate commits.

Describe alternatives you've considered

Testing

Additional context

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` Bionics CBM (Compact Bionic Modules) Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Info / User Interface Game - player communication, menus, etc. Map / Mapgen Overmap, Mapgen, Map extras, Map display Translation I18n json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Mar 30, 2023
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Mar 31, 2023
@dseguin dseguin merged commit 1df1844 into CleverRaven:master Mar 31, 2023
@BrettDong BrettDong deleted the clang-tidy-fix branch March 31, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Bionics CBM (Compact Bionic Modules) [C++] Changes (can be) made in C++. Previously named `Code` Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Info / User Interface Game - player communication, menus, etc. json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display Translation I18n
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BrettDong @dseguin