-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Further mutant scales refinements #64681
Merged
dseguin
merged 22 commits into
CleverRaven:master
from
anoobindisguise:anoobindisguise-scales2scaleharder
May 11, 2023
Merged
Further mutant scales refinements #64681
dseguin
merged 22 commits into
CleverRaven:master
from
anoobindisguise:anoobindisguise-scales2scaleharder
May 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[JSON]
Changes (can be) made in JSON
Items: Armor / Clothing
Armor and clothing
Mods
Issues related to mods or modding
Mods: Dinomod
Anything to do with the Dinoclysm mod (DinoMod)
Mods: Magiclysm
Anything to do with the Magiclysm mod
Mutations / Traits / Professions/ Hobbies
Mutations / Traits / Professions/ Hobbies
Game: Balance
Balancing of (existing) in-game features.
astyled
astyled PR, label is assigned by github actions
json-styled
JSON lint passed, label assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
labels
Mar 29, 2023
Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details. Click to expand
This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to |
github-actions
bot
removed
json-styled
JSON lint passed, label assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
labels
Mar 31, 2023
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions
bot
added
json-styled
JSON lint passed, label assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
labels
Mar 31, 2023
Got a materials conflict now 😢 |
github-actions
bot
removed
json-styled
JSON lint passed, label assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
labels
Apr 29, 2023
github-actions
bot
added
json-styled
JSON lint passed, label assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
labels
Apr 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
astyled
astyled PR, label is assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
Game: Balance
Balancing of (existing) in-game features.
Items: Armor / Clothing
Armor and clothing
[JSON]
Changes (can be) made in JSON
json-styled
JSON lint passed, label assigned by github actions
Mods: Dinomod
Anything to do with the Dinoclysm mod (DinoMod)
Mods: Magiclysm
Anything to do with the Magiclysm mod
Mods
Issues related to mods or modding
Mutations / Traits / Professions/ Hobbies
Mutations / Traits / Professions/ Hobbies
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Balance "one more stage of Scales mutations, adjust coverage, thresholdify sleek scales"
Purpose of change
I was discussing the matter with @Venera3 and it was noted that Scales mutations could use some more work.
Describe the solution
Sparse Scales has become a lower-tier "entry level" scales that is a requirement for "regular" Scales, which have more full coverage now. Sleek Scales is post thresh Fish only, similar to how Thick Scales is post thresh Lizard only.
In addition, I changed the Bone/Chitin dual layers to a single layer of "Mutant Scales" which is defensively in between bone and chitin.
Describe alternatives you've considered
Do two layers of mutant scales with less thickness and coverage.
Do different coverage and values.
Testing
Loaded up in game and they seem to be working OK. The mutations chain through rough skin->sparse scales->scales->sleek/thick scales.
Additional context