Deduplicate code for drawing labeled bars of chars #64367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[C++]
sparr
force-pushed
the
dedupe_get_colored_bar
branch
from
3d40456 to
73e5e68
Compare
|
This has several clang tidy warnings. |
sparr
force-pushed
the
dedupe_get_colored_bar
branch
from
73e5e68 to
3530a1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Existing code for drawing bars like
Foo: [***--. ], with or without color, is repetitiveDescribe the solution
Move repetitive code out to helper functions
Describe alternatives you've considered
I started with less templating but didn't like the results. I did consider defining the printer functions rather than using lambdas and could do that instead if requested.
Testing
Played around with ranged fire interface in different situations
Additional context