Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'vehicle' class cleanup 2 #64316

Merged
merged 3 commits into from
Mar 17, 2023
Merged

'vehicle' class cleanup 2 #64316

merged 3 commits into from
Mar 17, 2023

Conversation

irwiss
Copy link
Contributor

@irwiss irwiss commented Mar 17, 2023

Summary

None

Purpose of change

A few more cleanups in vehicle code

Describe the solution

Remove redundant dynamic_cast<>s in theft checking
Remove old bike rack migrations
Remove unused get_autodrive_target

Describe alternatives you've considered

Testing

Poked bike racks a bit, they should work, if save serialized in 0.G migration flag will be turned off anyway

Additional context

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` Vehicles Vehicles, parts, mechanics & interactions json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Mar 17, 2023
@irwiss irwiss marked this pull request as ready for review March 17, 2023 03:11
@kevingranade kevingranade merged commit fccbe02 into CleverRaven:master Mar 17, 2023
@irwiss irwiss deleted the veh-class-cleanup-2 branch March 17, 2023 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions Vehicles Vehicles, parts, mechanics & interactions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@irwiss @kevingranade