Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make Bulging Reservoir decrease your thirst, not increase #64306

Merged
merged 1 commit into from
Mar 17, 2023

Conversation

GuardianDll
Copy link
Member

@GuardianDll GuardianDll commented Mar 16, 2023

Summary

None

Purpose of change

Bulging Reservoir description says it should decrease the person's thirst, but instead it increases it for 75%

Describe the solution

swap 75% increase with 25% decrease, as intended

Describe alternatives you've considered

Testing

done

Additional context

8k strings in mutation.json is a mess

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Mar 16, 2023
@Maleclypse
Copy link
Member

I'd rather this actually allowed the player to store more liquid but that would require c++ changes.

@GuardianDll
Copy link
Member Author

Depend on what you mean by "stored" - it can be a common integrated armor/pocket, which can contain only water

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Mar 17, 2023
@Maleclypse
Copy link
Member

Depend on what you mean by "stored" - it can be a common integrated armor/pocket, which can contain only water

I meant by moving the maximum negative thirst.

@Rivet-the-Zombie Rivet-the-Zombie merged commit 670dc01 into CleverRaven:master Mar 17, 2023
@GuardianDll GuardianDll deleted the thirst branch March 17, 2023 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.H backport candidate astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants