Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress more clang-analyzer warnings #64292

Merged

Conversation

jbytheway
Copy link
Contributor

Summary

None

Purpose of change

These are a handful of false-positive warnings in idl_parser.cpp all of which have the same essential root cause: the analyzer cannot follow the ECHECK logic where an error return from some function causes an early return from the calling function. Thus it assumes some value can be left null or uninitialized when in fact it cannot.

Describe the solution

Suppress the warnings.

Describe alternatives you've considered

Updating clang-tidy?

Testing

Run clang-tidy.

Additional context

These are a handful of false-positive warnings in idl_parser.cpp all of
which have the same essential root cause: the analyzer cannot follow the
ECHECK logic where an error return from some function causes an early
return from the calling function.  Thus it assumes some value can be
left null or uninitialized when in fact it cannot.
@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Mar 16, 2023
@kevingranade kevingranade merged commit c6c31cf into CleverRaven:master Mar 17, 2023
@jbytheway jbytheway deleted the more-clang-tidy-suppressions branch March 18, 2023 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants