Suppress more clang-analyzer warnings #64292
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
These are a handful of false-positive warnings in idl_parser.cpp all of which have the same essential root cause: the analyzer cannot follow the ECHECK logic where an error return from some function causes an early return from the calling function. Thus it assumes some value can be left null or uninitialized when in fact it cannot.
Describe the solution
Suppress the warnings.
Describe alternatives you've considered
Updating clang-tidy?
Testing
Run clang-tidy.
Additional context